-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close select on escape key #645
Conversation
Deploying with Cloudflare Pages
|
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
==========================================
- Coverage 23.51% 22.13% -1.39%
==========================================
Files 221 221
Lines 12607 13181 +574
Branches 235 236 +1
==========================================
- Hits 2965 2917 -48
- Misses 9553 10174 +621
- Partials 89 90 +1 ☔ View full report in Codecov by Sentry. |
It fixes the original problem but it introduces other ones. Keyboard navigation is broken CleanShot.2024-02-08.at.14.42.33.mp4 |
@stropitek Fixed, Could you please recheck categories-nested story. |
Ref: #622 Did you base your resolution on palantir/blueprint#4244 (comment)? |
This solution also have the same problem "Keyboard navigation is broken". |
Fixed, Could you check please? |
Mouse interaction is broken CleanShot.2024-02-12.at.18.22.00.mp4I think this component library is a great source of inspiration for how accessible components should work: If possible we should try to mimic their behavior |
You can check what radix-ui has in terms of nested menus. If blueprintjs is too broken maybe it's possible to mix the accessibility of radix-ui with the presentation of blueprintjs |
I fixed what you mentioned. |
I think blueprintjs components are good but the examples in the documentation are not enough |
It is good enough for now. Anyway I think nested menu aren't really a thing we should use in a select component. It makes more sense in a dropdown menu. |
closes : #632
closes : #622