Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select does not close on escape key #632

Closed
stropitek opened this issue Jan 9, 2024 · 2 comments · Fixed by #645
Closed

Select does not close on escape key #632

stropitek opened this issue Jan 9, 2024 · 2 comments · Fixed by #645
Assignees
@wadjih-bencheikh18
Labels
bug Something isn't working

Comments

@stropitek
Copy link
Contributor

This is especially confusing when used in modals because then the modal closes.

In the examples of the documentation of bluprintjs, Esc closes the select list.

https://blueprintjs.com/docs/#select/select-component
@stropitek stropitek added the bug Something isn't working label Jan 9, 2024
@wadjih-bencheikh18
Copy link
Member

It's only working for filtrable Select in https://blueprintjs.com/docs/#select/select-component I think they have a bug
I'm using Popover autofocus with no portal which is working

@wadjih-bencheikh18 wadjih-bencheikh18 mentioned this issue Feb 3, 2024
Merged
@wadjih-bencheikh18 wadjih-bencheikh18 linked a pull request Feb 3, 2024 that will close this issue
Close select on escape key #645
Merged
@stropitek
Copy link
Contributor Author

palantir/blueprint#4243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wadjih-bencheikh18 wadjih-bencheikh18

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close select on escape key zakodium-oss/react-science
2 participants
@stropitek @wadjih-bencheikh18