Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load ium state #267

Merged
merged 7 commits into from
Nov 4, 2022
Merged

Conversation

wadjih-bencheikh18
Copy link
Member

closes #216

@netlify
Copy link

netlify bot commented Oct 21, 2022

Deploy Preview for analysis-ui-components ready!

Name Link
🔨 Latest commit 57a3c1a
🔍 Latest deploy log https://app.netlify.com/sites/analysis-ui-components/deploys/63520e2297e1c7000942b02b
😎 Deploy Preview https://deploy-preview-267--analysis-ui-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Base: 92.40% // Head: 91.67% // Decreases project coverage by -0.73% ⚠️

Coverage data is based on head (6f7cf25) compared to base (e6235f6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   92.40%   91.67%   -0.74%     
==========================================
  Files          10       10              
  Lines         685      757      +72     
  Branches      111      122      +11     
==========================================
+ Hits          633      694      +61     
- Misses         52       63      +11     
Impacted Files Coverage Δ
src/app/data/append.ts 98.14% <100.00%> (ø)
src/app/data/loaders/cdfLoader.ts 91.66% <0.00%> (-5.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lpatiny lpatiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is ok for me.

@targos targos requested a review from stropitek October 21, 2022 06:05
Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading an .ium file should be a separate path than loading other types of files, and it's not a "loader".

You should check if the file collection contains a unique nmrium file. If yes replace the current app state with the new state. If not use the loaders to add measurements.

src/app/App.tsx Outdated Show resolved Hide resolved
src/app/data/append.ts Outdated Show resolved Hide resolved
src/app/data/loaders/iumLoader.ts Outdated Show resolved Hide resolved
src/app/App.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after my last comment is resolved

src/app/context/load.ts Outdated Show resolved Hide resolved
@stropitek stropitek merged commit 443572a into zakodium-oss:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save as '.ium' file and reload the file
4 participants