make ColumnFamily Sync #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed, very important to make RocksDB properly usable in async code. Besides, imho the current implementation is definitely flawed. Just looking at it from the Rust side ColumnFamily must either be Send + Sync or neither. Just Send definitely doesn't make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a long standing issue rust-rocksdb/rust-rocksdb#407 where because ColumnFamily is not Sync, we are not able to fetch all the cfs on startup and use them directly, instead, we are currently forced to call
cf_handleon every operation to get the cf which adds unnecessary overhead