actually enable jemalloc when feature is used on linux

zaidoon1 · Feb 26, 2024 · 10fd9af · 10fd9af
1 parent 528bbed
commit 10fd9af
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/librocksdb-sys/Cargo.toml b/librocksdb-sys/Cargo.toml
@@ -29,7 +29,7 @@ exclude = [
 
 [features]
 default = ["static"]
-jemalloc = ["tikv-jemalloc-sys"]
+jemalloc = ["tikv-jemalloc-sys", "pkg-config"]
 static = ["libz-sys?/static", "bzip2-sys?/static"]
 io-uring = ["pkg-config"]
 snappy = []

diff --git a/librocksdb-sys/build.rs b/librocksdb-sys/build.rs
@@ -218,8 +218,19 @@ fn build_rocksdb() {
 
     config.define("ROCKSDB_SUPPORT_THREAD_LOCAL", None);
 
-    if cfg!(feature = "jemalloc") {
-        config.define("WITH_JEMALLOC", "ON");
+    #[cfg(feature = "jemalloc")]
+    {
+        if target.contains("linux") {
+            pkg_config::probe_library("libjemalloc-dev")
+                .expect("The jemalloc feature was requested but libjemalloc-dev is not installed");
+            config.define("ROCKSDB_JEMALLOC", Some("1"));
+            config.define("JEMALLOC_NO_DEMANGLE", Some("1"));
+        } else {
+            // this doesn't actually enable jemalloc, but mac/windows needs more
+            // work to make it work (statically link tikv-jemalloc). For now,
+            // I'll keep this as is.
+            config.define("WITH_JEMALLOC", "ON");
+        }
     }
 
     #[cfg(feature = "io-uring")]