-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0 release #323
4.0 release #323
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis commit introduces significant enhancements to the R package's testing and documentation processes. A new GitHub Actions workflow for R-hub automates the building and checking of R packages across various platforms. Additionally, the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (4)
- .github/workflows/rhub.yaml (1 hunks)
- DESCRIPTION (1 hunks)
- Makefile (5 hunks)
- cran-comments.md (1 hunks)
Files skipped from review due to trivial changes (1)
- cran-comments.md
Additional comments not posted (5)
DESCRIPTION (1)
35-37
: Approved: Addition ofpkgdown
andrhub
toSuggests
.The inclusion of
pkgdown
andrhub
enhances documentation capabilities and cross-platform testing, aligning with the PR objectives..github/workflows/rhub.yaml (1)
1-95
: Approved: Addition of R-hub GitHub Actions workflow.This workflow enhances cross-platform testing capabilities, aligning with the goals of improving package compatibility and usability.
Makefile (3)
22-23
: Approved: Addition ofcheck-win
andcheck-rhub
commands.These commands enhance cross-platform validation, improving the robustness of the testing strategy.
138-147
: Approved: Implementation ofcheck-win
andcheck-rhub
targets.These targets ensure the package is tested on winbuilder and rhub platforms, aligning with the PR objectives of cross-platform compatibility.
149-151
: Approved: Update torelease
target to include platform checks.Requiring
check-rhub
andcheck-win
before release enhances the reliability of the deployment process.
couple more 4.0 CRAN fixes