Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Php port modernisation #195

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Php port modernisation #195

wants to merge 13 commits into from

Conversation

loguntsov
Copy link

php port modernization:

  1. Can change template php code
  2. Can use only $1 in PHP-code
  3. Add grammar example
  4. Fix error syntax error message didn't show
  5. Fix bug when symbol = '0' at the end of string generate parse error
  6. UTF-8 support at lexer regexp
  7. Change generate exceptions for Lexer and Parser
  8. UTF8 support when generates error messages.
  9. RunTimeError - special error exception which is available from grammar code.

@zaach zaach mentioned this pull request Jun 24, 2014
Closed
damienalexandre
damienalexandre reviewed Sep 22, 2014
View reviewed changes
ports/php/template.php
}

protected function runTimeError(RunTimeError $error) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs instead of space here.

@damienalexandre
Copy link

Lots of tabs/spaces mixing, but beside that, 👍 for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loguntsov @damienalexandre