Hooks: Use load_hook to support python >= 3.12 | < 3.5
#746
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes z411#736 Signed-off-by: Mubashshir <ahmubashshir@gmail.com>
FichteFoll
requested changes
Jan 7, 2025
Comment on lines
+315
to
+317
| except ImportError: | ||
| def load_hook(loader, name): | ||
| return loader.find_module(name).load_module(name) |
There was a problem hiding this comment.
trackma currently requires Python 3.8, so we don't need this fallback code for <3.5 (which is ancient).
There was a problem hiding this comment.
I'm stuck in implementing this here... loader.find_module().load_module() allowed importing sibling packages, but newer one doesn't... so I'm stuck on this... Is there any way to do this without resorting to sys.path modification?
There was a problem hiding this comment.
Guess I'll have to take a look at testing this myself. No promises when I'll get to that, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #736
Signed-off-by: Mubashshir ahmubashshir@gmail.com