Issues with using omittedFromToc setting on Windows

[axxie]

I would like to report some issues with using omittedFromToc setting on Windows.

1. Paths relative to the workspace do not work in omittedFromToc setting on Windows. The extension contains the code that attempts to change portion of the doc.fileName to an empty string for future search using relative path. It uses a string with absolute workspace path and slash character as a search pattern for replace. However, on Windows the doc.fileName contains backslash character, not slash, so the replace does not work. Because of this, the workspace relative paths do not work. The mentioned code is here:
   

   vscode-markdown/src/toc.ts

   Lines 78 to 83 in 7d7d9d9

   	// If we are not in a workspace (i.e. in a standalone file), use the absolute path.
   	// Otherwise, use the workspace relative path.
   	const currentPath = docWorkspace
   	? doc.fileName.replace(`${docWorkspace.uri.fsPath}/`, '')
   	: doc.fileName;

2. The replace and search in the settings is case-sensitive. However, the paths on Windows are mostly case-insensitive.

For now, the only way to use omittedFromToc setting on Windows is to use absolute paths and use non-capital character for drive letter (the first one in path), like this:

{
    "settings": {
        "markdown.extension.toc.omittedFromToc": {
            "c:\\MyProjects\\project\\README.md": [
                "## Table of contents"
            ]
        }
    }
}

[yzhang-gh]

Thanks for your suggestion. It should be fixed in the dev build.

[i-keliukh]

Thanks for your suggestion. It should be fixed in the dev build.

I checked the fix.

1. The issue with drive letter is fixed.
2. The issue with relative path is not fixed.

The reason is still slash character in the replace:

vscode-markdown/src/toc.ts

Lines 87 to 89 in 62b0af5

	let currentPath = docWorkspace
	? doc.fileName.replace(`${docWorkspace.uri.fsPath}/`, '')
	: doc.fileName;

doc.filename contains backslashes, not slashes, so replace cannot find the workspace path with slash.

[yzhang-gh]

Thanks!

I was trying to patch this part of code which came from a PR 😂. I have reworked it and now it should work better.

[i-keliukh]

I confirm that the issue is fixed