Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable path autocomplete #614

Closed
gohma231 opened this issue Feb 7, 2020 · 5 comments
Closed

Disable path autocomplete #614

gohma231 opened this issue Feb 7, 2020 · 5 comments
Labels
Area: Auto completion Code completion and suggestion, aka IntelliSense. Needs Tag fix Does not meet label requirements. Res: Fixed Fix is checked in, but it might be a few weeks until a release.

Comments

@gohma231
Copy link

gohma231 commented Feb 7, 2020

What is the problem?

I use VSCode in a very large network drive and take notes in Markdown using this extension. VSCode will eat up RAM when I try to link to another file as it searches all directories for suitable files to link. Eventually VSCode will crash as Windows runs out of ram to give it.

The process that is created is called "Rg", but only gets created when Markdown-All-In-One is enabled AND I attempt to link to another file (such as via ![]() or [](). Disabling the extension fixes the issue. The extension Path Autocomplete works flawlessly by only sowing results for the directory I am in. It does not search for other files.

Note; I really like the fact that it searches for files to link to when in much smaller directories. If a toggle could be added to enable / disable this feature though, I would appreciate it for this particular use case.

How can I reproduce it?

In a directory with a LOT of files (on the order of hundreds of GB). Try to link to a file using []()

@yzhang-gh
Copy link
Owner

Thanks for the feedback.

Can you tell me more about the directory with hundreds of GB files? (For example, we now have heuristic which is to exclude node_modules folders.)

A toggle can be the solution. But I think there might be better ways to deal with it.
(If you open such a big folder with VSCode, sooner or later there will/might be some problems. For example, Todo Tree)

@gohma231
Copy link
Author

gohma231 commented Feb 7, 2020

Almost all of it is text files. I did forget to mention one key point (which may work as a better fix). I have set VSCode NOT to search in sub-directories which contain most of the files (say, 99% of the directory size). Before I did this, if I pressed ctrl + p (quick open), the "Rg" process would start and crash VSCode (with or without this extension).

Perhaps using the "Exclude" rules under Settings > Features > Search would be a better solution?

Example directory structure:

  • Notes (small)
    -- Markdown files
  • Directory with a ton of other text files (ignored from search)
    -- A whole bunch of text files!
  • Another huge directory (ignored)
    -- More text files!
  • Directory with scripts (on search path, not huge)
    -- Reasonably sized directory. Linking here would be useful, but I prefer VSCode not crashing

@yzhang-gh
Copy link
Owner

Perhaps using the "Exclude" rules under Settings > Features > Search would be a better solution?

That's a good idea.

@yzhang-gh yzhang-gh added the Area: Auto completion Code completion and suggestion, aka IntelliSense. label Feb 7, 2020
yzhang-gh added a commit that referenced this issue Feb 7, 2020
@yzhang-gh
Copy link
Owner

Please try out the dev build.

@yzhang-gh yzhang-gh added the Res: Fixed Fix is checked in, but it might be a few weeks until a release. label Feb 7, 2020
@gohma231
Copy link
Author

gohma231 commented Feb 8, 2020

Dev build worked perfectly! Thank you!

@Lemmingh Lemmingh added the Needs Tag fix Does not meet label requirements. label Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Auto completion Code completion and suggestion, aka IntelliSense. Needs Tag fix Does not meet label requirements. Res: Fixed Fix is checked in, but it might be a few weeks until a release.
Projects
None yet
Development

No branches or pull requests

3 participants