-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect TOC for reference link #515
Comments
Thanks for the feedback. (related #494) We need an efficient way to strip off the Markdown syntax in the headings. |
It should be fixed in the dev build. |
Out of curiosity, why was my comment marked as off-topic? It was about the issue no longer being fixed (at least for me). |
I was misled by the image. Thought it was another issue 😅. I remember I have reverted the fix of this issue but cannot remember the reason now. |
Looks like this issue has been considered in the code. In case someone would like to have a look. Lines 111 to 113 in c83296e
|
Think I figured it out, it looks like Lines 136 to 137 in c83296e
Looks like it was changed in fe6a14f#diff-3a050df20b3a1c2ba3272cb808d6ab8b. I've tested just moving the regex in line 136 to I'll be creating a pull request for that in a minute. |
It looks like some tests failed. Let's remove Markdown syntax like |
Done. |
It should be fixed in the dev build. |
Thanks for fixing it! One small problem still: the regex does NOT match shortcut-style links ( It looks like changing the regex to make the second set of brackets optional fixes that ( |
What is the problem?
How can I reproduce it?
Is there any error message in the console?
The text was updated successfully, but these errors were encountered: