Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Dead players in gray on scoreboard #654

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

NotAFile
Copy link
Contributor

@NotAFile NotAFile commented Sep 7, 2017

This is done for all cases, but that is probably a bad idea. While this
does not matter in public games, in small tournaments this could be an
advantage. Ideally, the server could disable giving players this
information.

Another option is to enable it only above a certain player count or only on arena mode for now.

This is done for all cases, but that is probably a bad idea. While this
does not matter in public games, in small tournaments this could be an
advantage. Ideally, the server could disable giving players this
information
@NotAFile
Copy link
Contributor Author

NotAFile commented Jan 2, 2018

Well, this actually isn't WIP. But You might want to request certain changes.

@NotAFile NotAFile changed the title WIP: Show Dead players in gray on scoreboard Show Dead players in gray on scoreboard Jan 2, 2018
@yvt yvt merged commit 399e240 into yvt:master Feb 21, 2018
@NotAFile
Copy link
Contributor Author

Hm, I'm not sure you actually want to merge it without condition like it actually is right now, as it gives players more information. My suggestion would be to only implement it if spectator or more than 12 players are on the server. 6 players is the point I figure it will be hard to keep track of enemy players.

@yvt
Copy link
Owner

yvt commented Feb 21, 2018

I assumed everyone has agreed upon merging this patch at this state. Well then, yeah, this should be feature-gated depending on some conditions. I’m actually for controlling the behavior via a server-side flag passed by a newly introduced packet type.

@NotAFile
Copy link
Contributor Author

Sure, that would be good, but that's still a bit far out, I'd rather strictly feature-gate it now and then allow setting it on the server later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants