Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds QueryID and QueryAnnotationID to Boards #16

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Conversation

tyler-boyd
Copy link
Contributor

No description provided.

@yvrhdn
Copy link
Owner

yvrhdn commented Apr 23, 2021

Hi Tyler, sorry for the delayed review. Can you also update the tests in board_test.go and query_spec_test.go? Running the tests locally causes compilation errors:

$ go test .
# github.com/kvrhdn/go-honeycombio [github.com/kvrhdn/go-honeycombio.test]
./board_test.go:31:6: cannot use QuerySpec{...} (type QuerySpec) as type *QuerySpec in field value
./board_test.go:77:4: cannot use QuerySpec{...} (type QuerySpec) as type *QuerySpec in field value
./query_spec_test.go:62:5: cannot use query (type QuerySpec) as type *QuerySpec in field value
./query_spec_test.go:109:47: cannot use q (type QuerySpec) as type *QuerySpec in field value
./query_spec_test.go:150:47: cannot use q (type QuerySpec) as type *QuerySpec in field value
FAIL    github.com/kvrhdn/go-honeycombio [build failed]
FAIL

@tyler-boyd
Copy link
Contributor Author

Thanksi @kvrhdn, I have updated the tests in this PR! They work for me locally, hopefully same for you.

@tyler-boyd tyler-boyd changed the title Adds support for QueryID and QueryAnnotationID Adds QueryID and QueryAnnotationID to Boards Apr 26, 2021
Copy link
Owner

@yvrhdn yvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good thanks! This contains a breaking change, so it will be a version bump.

@yvrhdn yvrhdn merged commit b58076a into yvrhdn:main Apr 27, 2021
@yvrhdn
Copy link
Owner

yvrhdn commented Apr 27, 2021

By creating a release these changes are now also visible on pkg.go.dev: https://pkg.go.dev/github.com/kvrhdn/go-honeycombio@v0.3.0 🎉

@tyler-boyd
Copy link
Contributor Author

tyler-boyd commented Apr 28, 2021

🎉 Thanks! When I create a new PR for the boards changes in the provider I will reference this version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants