-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added float64 support #7
Conversation
Hey, thanks for contribution 👋 Or at least you can share an example that this change improves. |
Certainly, I'll gladly enrich the PR description to provide more clarity on the issue and the expected behavior. |
Tested the usecase and it works! Thanks! |
Added float64 support by @bilinenkisi (yusufpapurcu#7)
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/yusufpapurcu/wmi](https://togithub.com/yusufpapurcu/wmi) | `v1.2.3` -> `v1.2.4` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fyusufpapurcu%2fwmi/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fyusufpapurcu%2fwmi/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fyusufpapurcu%2fwmi/v1.2.3/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fyusufpapurcu%2fwmi/v1.2.3/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>yusufpapurcu/wmi (github.com/yusufpapurcu/wmi)</summary> ### [`v1.2.4`](https://togithub.com/yusufpapurcu/wmi/releases/tag/v1.2.4) [Compare Source](https://togithub.com/yusufpapurcu/wmi/compare/v1.2.3...v1.2.4) #### What's Changed - Added float64 support by [@​bilinenkisi](https://togithub.com/bilinenkisi) in [yusufpapurcu/wmi#7 #### New Contributors - [@​bilinenkisi](https://togithub.com/bilinenkisi) made their first contribution in [yusufpapurcu/wmi#7 **Full Changelog**: yusufpapurcu/wmi@v1.2.3...v1.2.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
…telemetry#30862) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/yusufpapurcu/wmi](https://togithub.com/yusufpapurcu/wmi) | `v1.2.3` -> `v1.2.4` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fyusufpapurcu%2fwmi/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fyusufpapurcu%2fwmi/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fyusufpapurcu%2fwmi/v1.2.3/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fyusufpapurcu%2fwmi/v1.2.3/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>yusufpapurcu/wmi (github.com/yusufpapurcu/wmi)</summary> ### [`v1.2.4`](https://togithub.com/yusufpapurcu/wmi/releases/tag/v1.2.4) [Compare Source](https://togithub.com/yusufpapurcu/wmi/compare/v1.2.3...v1.2.4) #### What's Changed - Added float64 support by [@&open-telemetry#8203;bilinenkisi](https://togithub.com/bilinenkisi) in [yusufpapurcu/wmi#7 #### New Contributors - [@&open-telemetry#8203;bilinenkisi](https://togithub.com/bilinenkisi) made their first contribution in [yusufpapurcu/wmi#7 **Full Changelog**: yusufpapurcu/wmi@v1.2.3...v1.2.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
When i tried to use wmi.QueryNameSpace for Win32_ReliabilityStabilityMetrics with this struct:
I got error for SystemStabilityIndex field:
cannot load field "SystemStabilityIndex" into a "float64": unsupported type (float64)
even if i used float32 to fetch data, this time i got this error:
Özel durum oluştu. (Nesne sunucuya bağlanmamış )
and also for other variable types was same that are supported by the package. So, i added float64 support.