Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added float64 support #7

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Conversation

bilinenkisi
Copy link

@bilinenkisi bilinenkisi commented Dec 14, 2023

When i tried to use wmi.QueryNameSpace for Win32_ReliabilityStabilityMetrics with this struct:

type Win32_ReliabilityStabilityMetrics struct {
	EndMeasurementDate   time.Time `json:"end_measurement_date"`
	RelID                string    `json:"rel_id"`
	StartMeasurementDate time.Time `json:"start_measurement_date"`
	SystemStabilityIndex float64   `json:"system_stability_index"`
	TimeGenerated        time.Time `json:"time_generated"`
}

I got error for SystemStabilityIndex field: cannot load field "SystemStabilityIndex" into a "float64": unsupported type (float64)
even if i used float32 to fetch data, this time i got this error: Özel durum oluştu. (Nesne sunucuya bağlanmamış ) and also for other variable types was same that are supported by the package. So, i added float64 support.

@yusufpapurcu
Copy link
Owner

Hey, thanks for contribution 👋
Sorry I was on holidays so just saw this now, can you enrich the PR description a bit more about the issue you faced and expected behaviour? It would make it much easier to review 🙂

Or at least you can share an example that this change improves.

@bilinenkisi
Copy link
Author

bilinenkisi commented Jan 28, 2024

Certainly, I'll gladly enrich the PR description to provide more clarity on the issue and the expected behavior.

@yusufpapurcu
Copy link
Owner

Tested the usecase and it works! Thanks!

@yusufpapurcu yusufpapurcu merged commit 6c94d73 into yusufpapurcu:master Jan 28, 2024
sarog added a commit to jetrmm/go-wmi that referenced this pull request Feb 1, 2024
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Feb 15, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/yusufpapurcu/wmi](https://togithub.com/yusufpapurcu/wmi) |
`v1.2.3` -> `v1.2.4` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fyusufpapurcu%2fwmi/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fyusufpapurcu%2fwmi/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fyusufpapurcu%2fwmi/v1.2.3/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fyusufpapurcu%2fwmi/v1.2.3/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>yusufpapurcu/wmi (github.com/yusufpapurcu/wmi)</summary>

###
[`v1.2.4`](https://togithub.com/yusufpapurcu/wmi/releases/tag/v1.2.4)

[Compare
Source](https://togithub.com/yusufpapurcu/wmi/compare/v1.2.3...v1.2.4)

#### What's Changed

- Added float64 support by
[@&#8203;bilinenkisi](https://togithub.com/bilinenkisi) in
[yusufpapurcu/wmi#7

#### New Contributors

- [@&#8203;bilinenkisi](https://togithub.com/bilinenkisi) made their
first contribution in
[yusufpapurcu/wmi#7

**Full Changelog**:
yusufpapurcu/wmi@v1.2.3...v1.2.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
…telemetry#30862)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/yusufpapurcu/wmi](https://togithub.com/yusufpapurcu/wmi) |
`v1.2.3` -> `v1.2.4` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fyusufpapurcu%2fwmi/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fyusufpapurcu%2fwmi/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fyusufpapurcu%2fwmi/v1.2.3/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fyusufpapurcu%2fwmi/v1.2.3/v1.2.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>yusufpapurcu/wmi (github.com/yusufpapurcu/wmi)</summary>

###
[`v1.2.4`](https://togithub.com/yusufpapurcu/wmi/releases/tag/v1.2.4)

[Compare
Source](https://togithub.com/yusufpapurcu/wmi/compare/v1.2.3...v1.2.4)

#### What's Changed

- Added float64 support by
[@&open-telemetry#8203;bilinenkisi](https://togithub.com/bilinenkisi) in
[yusufpapurcu/wmi#7

#### New Contributors

- [@&open-telemetry#8203;bilinenkisi](https://togithub.com/bilinenkisi) made their
first contribution in
[yusufpapurcu/wmi#7

**Full Changelog**:
yusufpapurcu/wmi@v1.2.3...v1.2.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants