Dockerize #97
Merged
Dockerize #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, in the interest of shipping more quickly, one could mount a volume at the container's |
yunginnanet
added a commit
that referenced
this pull request
Aug 13, 2023
yunginnanet
reviewed
Aug 13, 2023
There was a problem hiding this comment.
Went ahead and set this up for you by adding a configuration directive to [logger] called docker_logging
I also implemented something else you might want to use for this before we merge. All configuration directives should now abide/be overridden by matching environment variables, example:
# [logger]
# docker_logging = true
HELLPOT_LOGGER_DOCKER_LOGGING=1 # "true" is also acceptable
# [http]
# bind_addr = "0.0.0.0"
HELLPOT_HTTP_BIND_ADDR="0.0.0.0"
yunginnanet
previously approved these changes
Aug 13, 2023
|
you'll need to sign your commit for sure either way thanks for the pr |
|
Works for me! I'll wipe the TODO and push a signed commit. |
yunginnanet
approved these changes
Aug 13, 2023
|
appreciate you, cuzzin |
|
/release tag=v0.4.0 |
yunginnanet
added a commit
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm leaving it in draft mode because I'd like to fix the logger (it should output to stdout and only stdout), but I don't yet have the Go skill for doing that.
Closes #53.