Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lean to v4.6.0 #33

Merged
merged 3 commits into from
Apr 6, 2024
Merged

Conversation

Seasawher
Copy link
Contributor

@Seasawher Seasawher commented Mar 29, 2024

resolve #32

Lean のバージョンを v4.6.0 に更新し,併せて mathlib も更新しました.

mathlib には FunLike の修正が入っていて,それによりエラーが発生していたので解消しました.

@yuma-mizuno
Copy link
Owner

@Seasawher 該当するFunLikeの修正のPRの場所を教えていただいてもよいですか?

@Seasawher
Copy link
Contributor Author

mathlibにその変更を入れたプルリクということですか?
いまあまり作業できる状況にないのですが、FunLikeのgit blameから確認できると思います。

@Seasawher
Copy link
Contributor Author

leanprover-community/mathlib4#9785

このPRです

@Seasawher
Copy link
Contributor Author

@yuma-mizuno ご確認ください

Copy link
Owner

@yuma-mizuno yuma-mizuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。一箇所の提案部分を除いて、良さそうに見えます。

Solution/Advanced/Category/Lecture1.lean Outdated Show resolved Hide resolved
Co-authored-by: Yuma Mizuno <mizuno.y.aj@gmail.com>
@Seasawher
Copy link
Contributor Author

@yuma-mizuno 修正しました

@yuma-mizuno yuma-mizuno merged commit 14cf67a into yuma-mizuno:master Apr 6, 2024
1 check passed
@Seasawher Seasawher deleted the update-lean branch April 6, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update Lean version to v4.6.0
2 participants