Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding github actions #61

Closed
wants to merge 1 commit into from
Closed

Conversation

gingerlime
Copy link
Collaborator

@gingerlime gingerlime commented Sep 10, 2021

* based on https://dev.to/pikachuexe/ruby-gems-ci-using-github-action-136o
* note that there's no direct equivalent to allow_failures
  see https://dev.to/pikachuexe/ruby-gems-ci-using-github-action-136o
  so there's only a workaround, which requires you to include specific
  combinations of the matrix ...
* removed old .travis.yml
* updated and fixed code and specs for yuki24#59
* TODO?:
  - [ ] check that coverage is similar to travis
  - [ ] refresh ruby / rails versions
  - [ ] deprecate some older versions
@gingerlime
Copy link
Collaborator Author

@yuki24 did you get a chance to take a look ? ;-)

@yuki24
Copy link
Owner

yuki24 commented Sep 20, 2021

I've been busy these days and did not have time to do open source work. Please be patient until the dust gets settled...

@gingerlime
Copy link
Collaborator Author

I completely understand. Thank you.

@yuki24 yuki24 mentioned this pull request Sep 22, 2021
@yuki24
Copy link
Owner

yuki24 commented Sep 22, 2021

I have merged your commit fcd71ab in the other PR actions/toolkit#63. For some reason Actions is not running the builds with your workflow files so I started from scratch. I'm not sure why something fixed it.

The other change I made is to extract Rails edge and Ruby edge builds out of the big build config:

rails_edge:
strategy:
matrix:
ruby_version:
- '3.0'
- '2.7'
gemfile:
- gemfiles/rails_edge.gemfile
runs-on: ubuntu-18.04
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
steps:
- uses: actions/checkout@v2
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby_version }}
bundler-cache: true
- run: bundle exec rake
ruby_edge:
strategy:
matrix:
ruby_version:
- 'ruby-head'
gemfile:
- gemfiles/rails_edge.gemfile
- gemfiles/rails_61.gemfile
- gemfiles/rails_60.gemfile
runs-on: ubuntu-18.04
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
steps:
- uses: actions/checkout@v2
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby_version }}
bundler-cache: true
- run: bundle exec rake || echo "Ruby edge test is done."

This way we don't have to worry about misconfigurations for the stable builds that are more important.

Thanks for the help! Really appreciated.

@yuki24 yuki24 closed this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants