-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding github actions #61
Conversation
* based on https://dev.to/pikachuexe/ruby-gems-ci-using-github-action-136o * note that there's no direct equivalent to allow_failures see https://dev.to/pikachuexe/ruby-gems-ci-using-github-action-136o so there's only a workaround, which requires you to include specific combinations of the matrix ... * removed old .travis.yml * updated and fixed code and specs for yuki24#59 * TODO?: - [ ] check that coverage is similar to travis - [ ] refresh ruby / rails versions - [ ] deprecate some older versions
f03e60e
to
fcd71ab
Compare
@yuki24 did you get a chance to take a look ? ;-) |
I've been busy these days and did not have time to do open source work. Please be patient until the dust gets settled... |
I completely understand. Thank you. |
I have merged your commit fcd71ab in the other PR actions/toolkit#63. For some reason Actions is not running the builds with your workflow files so I started from scratch. I'm not sure why something fixed it. The other change I made is to extract Rails edge and Ruby edge builds out of the big build config: rambulance/.github/workflows/tests.yml Lines 71 to 110 in 1b01aad
This way we don't have to worry about misconfigurations for the stable builds that are more important. Thanks for the help! Really appreciated. |
see Please support something like "allow-failure" for a given job actions/runner#2347
so there's only a workaround, which requires you to include specific
combinations of the matrix ...