[experimental][discussion] introducing baseBase
setting to support base
inheritance for groups
#1720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upcoming SPDY support, we will have more and more applications using
combine: false
(combo is an anti-pattern when serving assets using SPDY), also, we will see some benefits when serving all assets from the same domain (yes, domain sharding is also an anti-pattern when using SPDY). In an effort to consolidate the inheritance of configurations from groups from the master settings to minimize the amount of settings to define per group, we are proposing to have a new configuration option calledbaseBase
.baseBase
works similar tocomboBase
, which has to be completed with theroot
value to form the path to a module. IfbaseBase
is specified at the top level, along withcomboBase
, androot
is defined at the top level and per group, then it will be simpler to infer thebase
value per group based on the globalbaseBase
.The ideal configuration will be:
In the example above, whether we use use combine or not, the
base
does not have to be defined, because it can be computed based onbaseBase
and the correspondingroot
value.Few more thoughts:
base
is king. If it is set, it will not be combined, so this change is BC.baseBase
CANNOT be infer from parsing the seed url, it always have to be defined manually (BC too).Open questions:
combine
be inherited/computed as well?