Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] removed SET TABLESPACE #5998

Merged
merged 5 commits into from
Oct 13, 2020
Merged

[DOCS] removed SET TABLESPACE #5998

merged 5 commits into from
Oct 13, 2020

Conversation

ddorian
Copy link
Contributor

@ddorian ddorian commented Oct 9, 2020 •
edited
Loading

alter database:
image

create database
image

@ddorian ddorian added the area/documentation Documentation needed label Oct 9, 2020
@ddorian ddorian requested a review from stevebang October 9, 2020 08:14
@ddorian ddorian linked an issue Oct 9, 2020 that may be closed by this pull request
[docs] Remove unsupported "SET TABLESPACE new_tablespace" in ALTER DATABASE statement #5991
Closed
stevebang
stevebang approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@stevebang stevebang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

stevebang
stevebang suggested changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@stevebang stevebang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the diagram file? If you edited the EBNF file and ran the rrdiagram.jar generator, there would be two changed files, one for the grammar and one for the diagram.

stevebang
stevebang suggested changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@stevebang stevebang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should also include deleting the "tablespace_name" section from the doc page.

@ddorian
Copy link
Contributor Author

ddorian commented Oct 10, 2020

@stevebang some commits weren't showing up.
Also made changes about create database.
Please recheck.

@stevebang stevebang self-requested a review October 13, 2020 07:51
stevebang
stevebang approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@stevebang stevebang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@ddorian ddorian merged commit c397ce0 into yugabyte:master Oct 13, 2020
@ddorian ddorian deleted the doc-remove-tablespace-alter branch October 13, 2020 07:55
bllewell added a commit that referenced this pull request Oct 15, 2020
@bllewell
Aggregate functions: brand-new content (#5993)
9baf00d 
Fixed txn_set.md

Removed immutable throughout JSON, Arrays, Window functions, and Aggregate functions. Typos corrected.

removed SET TABLESPACE to mimic Dorian's PR #5998

re-ran diagram generator for removed SET TABLESPACE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevebang stevebang stevebang approved these changes

Assignees
No one assigned
Labels
area/documentation Documentation needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Remove unsupported "SET TABLESPACE new_tablespace" in ALTER DATABASE statement
3 participants
@ddorian @stevebang @jaki