Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add replication lag script #4620

Merged
merged 7 commits into from
Jun 9, 2020

Conversation

ddorian
Copy link
Contributor

@ddorian ddorian commented May 29, 2020

image

@ddorian ddorian added the area/documentation Documentation needed label May 29, 2020
@ddorian ddorian requested review from stevebang and kmuthukk May 29, 2020 15:40
@@ -111,3 +111,31 @@ Connect to “yugabyte-consumer” universe using the YSQL shell (`ysqlsh`) or t
**For bidirectional replication**

Repeat the steps above, but pump data into “yugabyte-consumer”. To avoid primary key conflict errors, keep the key space for the two universes separate.


{{< note title="How to check replication lag" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{< note title="How to check replication lag" >}}
{{< note title="Note" >}}

The Note title is only intended for Note, Important, Warning, and other admonitions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevebang On the same page above it's a "tip" with a custom title Recommended Reading.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, letting it slide for now — this use and others should be handled differently. But, I will have to propose an alternative.

Copy link
Contributor

@stevebang stevebang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

ddorian and others added 4 commits June 1, 2020 23:27
Co-authored-by: Steve Bang <stevebang@gmail.com>
Co-authored-by: Steve Bang <stevebang@gmail.com>
Co-authored-by: Steve Bang <stevebang@gmail.com>
nicer explanation of formula
@ddorian
Copy link
Contributor Author

ddorian commented Jun 2, 2020

@stevebang see changes & comment

@ddorian ddorian linked an issue Jun 2, 2020 that may be closed by this pull request
@ddorian
Copy link
Contributor Author

ddorian commented Jun 2, 2020

@kmuthukk is the explanation correct on 93e4c03#diff-cffc50f158379b11e4f036551dbf53d3R123 and the following line ?

@ddorian
Copy link
Contributor Author

ddorian commented Jun 5, 2020

@stevebang can you recheck ?

@stevebang stevebang self-requested a review June 9, 2020 16:25
Copy link
Contributor

@stevebang stevebang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ddorian ddorian merged commit 5c642fc into yugabyte:master Jun 9, 2020
@ddorian ddorian deleted the docs-replication-lag branch June 9, 2020 17:22
deeps1991 pushed a commit to deeps1991/yugabyte-db that referenced this pull request Jul 22, 2020
* add replication lag script in 2DC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Explain replication lag in 2DC
2 participants