Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs][#4365] Make the default option for clickable queryHeaders to be h2 thru h6 #4366

Merged
merged 1 commit into from
May 1, 2020
Merged

[Docs][#4365] Make the default option for clickable queryHeaders to be h2 thru h6 #4366

merged 1 commit into from
May 1, 2020

Conversation

andrewc-dev
Copy link
Contributor

This code does not generate a permalink icon but does make the headers clickable as long as isTocNested is true but not a number.

@andrewc-dev andrewc-dev requested review from ddorian and stevebang May 1, 2020 20:21
stevebang
stevebang approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@stevebang stevebang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good. Not sure why when I tried changing queryHeaders earlier, it didn't work.

@andrewc-dev andrewc-dev merged commit ec8c70a into yugabyte:master May 1, 2020
@stevebang stevebang mentioned this pull request May 1, 2020
Merged
@ryan-ally ryan-ally mentioned this pull request Nov 30, 2023
Open
@ryan-ally ryan-ally mentioned this pull request Feb 11, 2024
Open
@nyndyny nyndyny mentioned this pull request Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevebang stevebang stevebang approved these changes

@ddorian ddorian Awaiting requested review from ddorian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewc-dev @stevebang