-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] PR for Documentation for multiple subscription support with azure #11609
Conversation
✔️ Deploy Preview for infallible-bardeen-164bc9 ready! 🔨 Explore the source changes: 00aefed 🔍 Inspect the deploy log: https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/621e78dd2fe50d00075da7f2 😎 Browse the preview: https://deploy-preview-11609--infallible-bardeen-164bc9.netlify.app |
@SergeyPotachev Could you, please, review and approve doc changes? |
|
||
![description](/images/yb-platform/install/azure/shared-gallery-replication.png) | ||
|
||
1. To use the image in Yugabyte Platform, enter the image version's resource ID into the **Marketplace Image URN/Shared Gallery Image ID** field of the **Specify Region Info** dialog. | ||
|
||
|
||
<br>Note that if you provide the resource ID, Yugabyte Platform infers the resource group from it. If you provide only the name, then Yugabyte Platform assumes that the resource group is the same as the group used in the cloud provider. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I haven't heard that we can provide only name. I think it should be a full URL otherwise it will be not picked up.
- This URL contains not only the resource group but subscription ID as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SergeyPotachev I guess I misunderstood your comment in the doc ticket: "The part about Private DNS Zone looks good enough. Also we need to add similar comments to a part related to Shared gallery image." I thought you suggested to add the Note from "How to define a private DNS zone" section to "How to use a shared image gallery" section, which I did.
Could you let me know what comments you'd like to be added to the Shared gallery image section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like I missed some things while was checking the Private DNS section. My apologies.
What we need to say:
Private DNS zone
could beid
only and in such case it will be used together with default subscription id and resource group; If it has subscription id and resource group then they will be used instead of default values;Gallery Image ID
could be a full URL only which should contain a subscription id, a resource group name and the resource name itself. If subscription id/resource group are different from the default ones, they will be used instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @SergeyPotachev.
Just to make sure I understand correctly, I have to do this:
- Delete "Note that if you provide the Resource ID, Yugabyte Platform infers the resource group from it. If you provide only the name, then Yugabyte Platform assumes that the resource group is the same as the group used in the cloud provider." from both sections.
- Add "Private DNS zone could be id only and in such case it will be used together with default subscription id and resource group; If it has subscription id and resource group then they will be used instead of default values." to the "How to define a private DNS zone" section.
- Add "Gallery Image ID could be a full URL only which should contain a subscription id, a resource group name and the resource name itself. If subscription id/resource group are different from the default ones, they will be used instead." to the "How to use a shared image gallery" section.
Could you, please, confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For item 2. "if it has subscription ..." should be something like "if it is a full URL which contains subscription ID and resource group..."
All other things look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ure (yugabyte#11609) * Added content; fixed list formatting. * Implemented review comments * copied changes to stable
Addresses https://yugabyte.atlassian.net/browse/PLAT-3115
Preview: https://deploy-preview-11609--infallible-bardeen-164bc9.netlify.app/latest/yugabyte-platform/configure-yugabyte-platform/set-up-cloud-provider/azure/#how-to-use-a-shared-image-gallery