Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YCQL] Fix timeout error in org.yb.cql.TestBigNumShards#testDropTableTimeout. #9826

Closed
m-iancu opened this issue Aug 25, 2021 · 0 comments
Closed
Assignees
Labels
area/ycql Yugabyte CQL (YCQL)

Comments

@m-iancu
Copy link
Contributor

m-iancu commented Aug 25, 2021

The test org.yb.cql.TestBigNumShards#testDropTableTimeout sets NumShardsPerTServer ==32.
For 1 table + 5 indexes it creates 192 tablets. For the many number of tablets Jenkins can occasionally fail with timeout.

The big number of tablets was a way to reproduce some cases when the DROP TABLE happens when the CREATE TABLE/INDEX is not finished.
See for details:

Planned fix:

  • Let's keep the test for big number of shards, but the number of tables (and indexes) reduced to 2.
  • Slow CREATE TABLE test-case will be re-implemented via TEST_simulate_slow_table_create_secs: org.yb.cql.TestSlowCreateTable#testDropTableTimeout .
@m-iancu m-iancu added the area/ycql Yugabyte CQL (YCQL) label Aug 25, 2021
OlegLoginov added a commit that referenced this issue Sep 5, 2021
…stDropTableTimeout.

Summary:
The test `org.yb.cql.TestBigNumShards#testDropTableTimeout` sets `NumShardsPerTServer `==32.
For 1 table + 5 indexes it created 192 tablets. For the many number of tablets Jenkins can occasionally fail with timeout.

The big number of tablets was a way to reproduce some cases when the DROP TABLE happens when the CREATE TABLE/INDEX is not finished.
See for details:
- GH: #3032
- Diff: https://phabricator.dev.yugabyte.com/D7670
- Commit: a70ab64

Current fix keeps the test for big number of shards, but the number of tables (and indexes) reduced to 2.
Slow CREATE TABLE test-case is re-implemented via `TEST_simulate_slow_table_create_secs`:  `org.yb.cql.TestMasterLatency#testSlowCreateDropIndex `.

Test Plan:
ybd --java-test org.yb.cql.TestBigNumShards#testCreateDropTable --tp 1 -n 10
ybd --java-test org.yb.cql.TestMasterLatency#testSlowCreateDropTable --tp 1 -n 10
ybd --java-test org.yb.cql.TestMasterLatency#testSlowCreateDropIndex --tp 1 -n 10
ybd --java-test org.yb.cql.TestSlowCreateTable#testCreateTableTimeout --tp 1 -n 10

Reviewers: timur, amitanand

Reviewed By: amitanand

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D12427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ycql Yugabyte CQL (YCQL)
Projects
None yet
Development

No branches or pull requests

2 participants