Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YCQL] KeySpace Names - compatibility #916

Closed
barum opened this issue Feb 27, 2019 · 5 comments
Closed

[YCQL] KeySpace Names - compatibility #916

barum opened this issue Feb 27, 2019 · 5 comments
Assignees
@nocaway
Labels
community/request Issues created by external users kind/enhancement This is an enhancement of an existing feature

Comments

@barum
Copy link

barum commented Feb 27, 2019

FYI:
in Cassandra i can name a Keyspace "static" or "references".
However in YCQL I can not create a Keyspace called "static" or "references".

This is a compatibility issue.
@kmuthukk kmuthukk added the kind/enhancement This is an enhancement of an existing feature label Feb 27, 2019
@kmuthukk
Copy link
Collaborator

kmuthukk commented Feb 27, 2019 •
edited
Loading

@nocaway

Would the work for this be similar to what you are doing right now for:
#835?

@barum
Copy link
Author

barum commented Feb 27, 2019

Yes but for Keyspace Name.

@nocaway nocaway changed the title CQL KeySpace Names - compatibility [YCQL] KeySpace Names - compatibility Feb 28, 2019
@nocaway
Copy link
Contributor

nocaway commented Feb 28, 2019 •
edited
Loading

@kmuthukk : For keywords, we'll go through them on case-by-case basics.

  • YugaByte reserves more keywords than Apache CQL because we planned to extend the language to support more features. Some of the keywords will be made unreserved, but not others.
  • In this case, "STATIC" will be made unreserved keyword as specified by Apache CQL.
  • REFERENCES will be removed from keyword list as its associated feature will not be added to the language.

'cc @barum

yugabyte-ci pushed a commit that referenced this issue Mar 1, 2019
@nocaway
[YCQL] #916 Making STATIC an unreserved-keyword. Removing REFERENCES …
d281ca0 
…from keyword list.

Summary:
- To be compatible with Apache CQL, STATIC is changed from reserved to unreserved keyword.
- REFERENCES is removed from YCQL as we don't plan to implement its associated feature.

Test Plan: TestKeyspace.java

Reviewers: robert

Reviewed By: robert

Subscribers: neha, yql

Differential Revision: https://phabricator.dev.yugabyte.com/D6256
@nocaway
Copy link
Contributor

nocaway commented Mar 1, 2019

This has been fixed by commit d281ca0

'cc @barum

@nocaway nocaway closed this as completed Mar 1, 2019
@kmuthukk
Copy link
Collaborator

kmuthukk commented Mar 1, 2019

Thanks @nocaway for taking care of this quickly!

@yugabyte-ci yugabyte-ci added the community/request Issues created by external users label Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nocaway nocaway

Labels
community/request Issues created by external users kind/enhancement This is an enhancement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@barum @kmuthukk @yugabyte-ci @nocaway