Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not submitted write operation should block tablet peer shutdown #891

Closed
spolitov opened this issue Feb 22, 2019 · 0 comments
Closed

Not submitted write operation should block tablet peer shutdown #891

spolitov opened this issue Feb 22, 2019 · 0 comments
Assignees
@spolitov
Labels
kind/bug This issue is a bug

Comments

@spolitov
Copy link
Contributor

When write operation completes, even with failure, it releases acquired resources.
So tablet peer should exists while operation is alive, otherwise tserver could crash when operation releases locks.
@spolitov spolitov added the kind/bug This issue is a bug label Feb 22, 2019
@spolitov spolitov self-assigned this Feb 22, 2019
yugabyte-ci pushed a commit that referenced this issue Feb 27, 2019
@spolitov
ENG-4717: #891: Not submitted write operation should block tablet pee…
3f4e225 
…r shutdown

Summary:
When a write operation completes, even with failure, it releases acquired resources.
So the tablet peer should exist while the operation is alive, otherwise the tablet server could crash when the operation releases locks.

Fixed by adding a counter of preparing operations.

Test Plan: ybd --java-test org.yb.cql.TestIndex#testDropDuringWrite

Reviewers: bogdan, mikhail

Reviewed By: mikhail

Subscribers: bharat, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D6221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
kind/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spolitov