Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis set options (ex: EX, NX, PX) should be case insensitive in yugabyte-db #86

Closed
rkarthik007 opened this issue Mar 7, 2018 · 0 comments
Closed

Redis set options (ex: EX, NX, PX) should be case insensitive in yugabyte-db #86

rkarthik007 opened this issue Mar 7, 2018 · 0 comments
Assignees
@hectorgcr

Comments

@rkarthik007
Copy link
Collaborator

Currently the server expects these options only in upper case. These should work in lower case as well.
yugabyte-ci pushed a commit that referenced this issue Mar 8, 2018
@hectorgcr
#86: Accept lowercase options for SET
897a925 
Summary: Redis supports lowercase options, and we don't. This fix addresses the issue.

Test Plan:
Before the change:
127.0.0.1:6379> set a 1 ex 1
(error) ERR set: Unidentified argument ex found while parsing set command
127.0.0.1:6379> set a 1 EX 1
OK
127.0.0.1:6379>

After the change:
127.0.0.1:6379> set a 1 ex 1
OK
127.0.0.1:6379> set a 1 EX 1
OK

Reviewers: karthik, pritam.damania, sergei, amitanand

Reviewed By: amitanand

Subscribers: kannan, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D4292
mbautin pushed a commit that referenced this issue Jun 20, 2019
@hectorgcr @schoudhury
Change diagnostics default collection level from low to medium (#86)
f328e17
jasonyb pushed a commit that referenced this issue Jun 11, 2024
@ibrarahmad
Merge pull request #86 from nastena1606/PG-198-Doc-update-accent-on-PPG
7934ccb 
PG-198 Update readme with more attention to Percona Distribution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hectorgcr hectorgcr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rkarthik007 @hectorgcr