Jedis test PublishSubscribeCommandsTest#handleClientOutputBufferLimitForSubscribeTooSlow fails against Yedis #771
Comments
yugabyte-ci
pushed a commit
that referenced
this issue
Feb 27, 2019
Summary: When we exceed the yedis buffering limits, the connection context is closed and the buffers are freed. But the underlying connection stays open. This change ensures that we the connection promptly when the buffer limits exceed. Test Plan: (YB-Jedis against yugabyte. Importing it in https://phabricator.dev.yugabyte.com/D6030) mvn test -Dtest=PublishSubscribeCommandsTest#handleClientOutputBufferLimitForSubscribeTooSlow Reviewers: hector, rahuldesirazu, sergei, mihnea Reviewed By: mihnea Subscribers: mihnea, yql Differential Revision: https://phabricator.dev.yugabyte.com/D6023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like when we exceed the buffer limits, the connection context is closed and the buffers are freed. But the underlying connection stays open.
It stays open until the next command is sent.
We should close the connection promptly when the buffer limits exceed.
The text was updated successfully, but these errors were encountered: