Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ping in subscribe mode should return a multi-bulk string #768

Closed
amitanandaiyer opened this issue Jan 17, 2019 · 0 comments
Closed

Ping in subscribe mode should return a multi-bulk string #768

amitanandaiyer opened this issue Jan 17, 2019 · 0 comments
Assignees
@amitanandaiyer

Comments

@amitanandaiyer
Copy link
Contributor

Ping response was switched from bulk string to simple string #345. However in subscribe mode, jedis seems to expect a bulk string.

vanilla redis-server also switches back and forth depending on weather the client is subscribed or not.

15:22 $ telnet 127.0.0.1 6379
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
auth foobared
+OK
ping
+PONG
ping
+PONG
subscribe foo
*3
$9
subscribe
$3
foo
:1
ping
*2
$4
pong
$0
@amitanandaiyer amitanandaiyer changed the title Ping in subscribe mode should return bulkstring Ping in subscribe mode should return a multi-bulk string Jan 17, 2019
@amitanandaiyer amitanandaiyer self-assigned this Jan 17, 2019
yugabyte-ci pushed a commit that referenced this issue Feb 27, 2019
@amitanandaiyer
#768 Ping in subscribe mode should return a multi-bulk string
6e06848 
Summary: Ping in subscribe mode should return a multi-bulk string

Test Plan:
redisserver-test
Also, Importing some jedis tests in https://phabricator.dev.yugabyte.com/D6030

Reviewers: hector, rahuldesirazu, sergei, mihnea

Reviewed By: mihnea

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D6021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amitanandaiyer amitanandaiyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amitanandaiyer