[Platform] Allow onprem nodes to be reused after releasing them #5703
Assignees
Labels
Comments
iSignal
pushed a commit
that referenced
this issue
Sep 23, 2020
…m from universe metadata Summary: 1. This diff aligns the OnPrem release node + re-add node flow to VM universes - releasing a node should not clear the universe metaedata for that node. To re-add the node, use the "Node -> Actions -> Add" flow instead of the "Edit Universe" flow. 2. Fixes bug introduced in D8405 3. Fixes bug introduced in https://phabricator.dev.yugabyte.com/D9097 - #5791 - releasing a node instance should only attempt to shut down processes on that node. 4. During an add node, we were not running the selection logic in NodeManager::pickNodes to select nodes from the onprem provider. Test Plan: 1. Create an onprem universe, release node, verify that an entry still remains in the universe nodes page. Verify that the node shows up as not in use on the provider node instances page. Verify that data is deleted from a node when it is released. 2. Verify that a newly created universe can pick up a released node. 3. Verify that a newly created universe can pick up a combination of new nodes and released nodes. Reviewers: arnav, daniel, ram, wesley Reviewed By: ram Subscribers: kannan, jenkins-bot, yugaware Differential Revision: https://phabricator.dev.yugabyte.com/D8825
iSignal
pushed a commit
that referenced
this issue
Sep 25, 2020
… not delete them from universe metadata Summary: 1. This diff aligns the OnPrem release node + re-add node flow to VM universes - releasing a node should not clear the universe metaedata for that node. To re-add the node, use the "Node -> Actions -> Add" flow instead of the "Edit Universe" flow. 2. Fixes bug introduced in D8405 3. Fixes bug introduced in https://phabricator.dev.yugabyte.com/D9097 - #5791 - releasing a node instance should only attempt to shut down processes on that node. 4. During an add node, we were not running the selection logic in NodeManager::pickNodes to select nodes from the onprem provider. Test Plan: 1. Create an onprem universe, release node, verify that an entry still remains in the universe nodes page. Verify that the node shows up as not in use on the provider node instances page. Verify that data is deleted from a node when it is released. 2. Verify that a newly created universe can pick up a released node. 3. Verify that a newly created universe can pick up a combination of new nodes and released nodes. Reviewers: arnav, wesley, daniel, zyu Reviewed By: daniel, zyu Subscribers: zyu, jenkins-bot, yugaware Differential Revision: https://phabricator.dev.yugabyte.com/D9441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The original commit to #4320 deleted the node from the universe_details_json completely when releasing onprem nodes. This made it so replacements needed to be done through the "Edit universe" flow. Instead, when an onprem node is released, the universe should keep an entry for the node and just clear the IP associated with it so a new node can be added later. The released node itself should have
in_useset to false so that it can be deleted or used in another universe.The text was updated successfully, but these errors were encountered: