Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master/tserver web UI shows IP even when --webserver_interface is set to a DNS name #5002

Closed
iSignal opened this issue Jul 8, 2020 · 0 comments
Assignees
Labels
area/docdb YugabyteDB core features

Comments

@iSignal
Copy link
Contributor

iSignal commented Jul 8, 2020

The web UI at port 7000/9000 still shows IP addresses when --webserver_interface, rpc_bind_addresses and server_broadcast_addresses for all nodes is set to DNS names.

Mentioned in #4950

@bmatican

@iSignal iSignal added the area/docdb YugabyteDB core features label Jul 8, 2020
@iSignal iSignal self-assigned this Jul 8, 2020
iSignal added a commit that referenced this issue Jul 21, 2020
…ecified in bind

cmd line flags

Summary:
The web UI at port 7000/9000 still shows IP addresses when --webserver_interface,
rpc_bind_addresses and server_broadcast_addresses for all nodes is set to DNS names. This diff makes
it use the same logic as rpc_bind_addresses, where the cmd line flag is used unchanged when only a
single non-wildcard address is used.

Test Plan:
1. Run masters/tservers with --webserver_interface set to a DNS name, verify that no IPs
show up for them.
1.1. Test above with an IPv6 address like [::1] and --net_address_filter=all
1.2 Test above with webserver_interface set to wildcards (0.0.0.0 and [::]) and verify regular IPs show up in the web interface.

Reviewers: hector, bogdan, raju

Reviewed By: raju

Subscribers: ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D8897
iSignal added a commit that referenced this issue Jul 22, 2020
…ecified in bind cmd line flags

Summary:
This is a port of 1403b2b to 2.1.8

The web UI at port 7000/9000 still shows IP addresses when --webserver_interface,
rpc_bind_addresses and server_broadcast_addresses for all nodes is set to DNS names. This diff makes
it use the same logic as rpc_bind_addresses, where the cmd line flag is used unchanged when only a
single non-wildcard address is used.

Test Plan:
Jenkins: auto rebase: no

1. Run masters/tservers with --webserver_interface set to a DNS name, verify that no IPs
show up for them.
1.1. Test above with an IPv6 address like [::1] and --net_address_filter=all
1.2 Test above with webserver_interface set to wildcards (0.0.0.0 and [::]) and verify regular IPs show up in the web interface.

Reviewers: bogdan, raju

Differential Revision: https://phabricator.dev.yugabyte.com/D8976
iSignal added a commit that referenced this issue Jul 22, 2020
…ecified in bind cmd line flags

Summary:
2.2.0 merge for 1403b2b

The web UI at port 7000/9000 still shows IP addresses when --webserver_interface,
rpc_bind_addresses and server_broadcast_addresses for all nodes is set to DNS names. This diff makes
it use the same logic as rpc_bind_addresses, where the cmd line flag is used unchanged when only a
single non-wildcard address is used.

Test Plan:
Jenkins: auto rebase: no

1. Run masters/tservers with --webserver_interface set to a DNS name, verify that no IPs
show up for them.
1.1. Test above with an IPv6 address like [::1] and --net_address_filter=all
1.2 Test above with webserver_interface set to wildcards (0.0.0.0 and [::]) and verify regular IPs show up in the web interface.

Reviewers: bogdan, raju

Reviewed By: raju

Differential Revision: https://phabricator.dev.yugabyte.com/D8975
@iSignal iSignal closed this as completed Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features
Projects
None yet
Development

No branches or pull requests

1 participant