Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log message about closing idle connection is confusing #4752

Closed
ttyusupov opened this issue Jun 11, 2020 · 0 comments
Closed

Log message about closing idle connection is confusing #4752

ttyusupov opened this issue Jun 11, 2020 · 0 comments
Assignees
@ttyusupov
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature

Comments

@ttyusupov
Copy link
Contributor

ttyusupov commented Jun 11, 2020 •
edited
Loading

Following log messages looks are confusing and periodically treated as errors by users:

I0611 06:23:58.795145 12268 reactor.cc:450] Master_R003: Timing out connection Connection (0x00000000027afc30) server 10.132.0.2:38383 => 10.128.0.11:7100 - it has been idle for 65.0003s (delta: 65.0003, current time: 34168.1, last activity time: 34103.1)
I0611 06:23:58.795548 12267 reactor.cc:450] Master_R002: Timing out connection Connection (0x00000000027af210) server 10.132.0.2:38643 => 10.128.0.11:7100 - it has been idle for 65.0993s (delta: 65.0993, current time: 34168.1, last activity time: 34103)
I0611 06:23:58.895499 12270 reactor.cc:450] Master_R005: Timing out connection Connection (0x00000000022cb7b0) server 10.132.0.2:59863 => 10.128.0.11:7100 - it has been idle for 65.0003s (delta: 65.0003, current time: 34168.2, last activity time: 34103.2)
@ttyusupov ttyusupov added kind/enhancement This is an enhancement of an existing feature area/docdb YugabyteDB core features labels Jun 11, 2020
@ttyusupov ttyusupov self-assigned this Jun 11, 2020
ttyusupov added a commit that referenced this issue Jun 11, 2020
@ttyusupov
#4752: Update log message about closing idle connection
d343860 
Summary:
Following log messages looks confusing and periodically treated as errors by users:
```
I0611 06:23:58.795145 12268 reactor.cc:450] Master_R003: Timing out connection Connection (0x00000000027afc30) server 10.132.0.2:38383 => 10.128.0.11:7100 - it has been idle for 65.0003s (delta: 65.0003, current time: 34168.1, last activity time: 34103.1)
I0611 06:23:58.795548 12267 reactor.cc:450] Master_R002: Timing out connection Connection (0x00000000027af210) server 10.132.0.2:38643 => 10.128.0.11:7100 - it has been idle for 65.0993s (delta: 65.0993, current time: 34168.1, last activity time: 34103)
I0611 06:23:58.895499 12270 reactor.cc:450] Master_R005: Timing out connection Connection (0x00000000022cb7b0) server 10.132.0.2:59863 => 10.128.0.11:7100 - it has been idle for 65.0003s (delta: 65.0003, current time: 34168.2, last activity time: 34103.2)
```

Updated it to be like:
```
I0611 06:23:58.795145 12268 reactor.cc:450] Master_R003: DEBUG: Closing idle connection: Connection (0x00000000027afc30) server 10.132.0.2:38383 => 10.128.0.11:7100 - it has been idle for 65.0003s
I0611 06:23:58.795548 12267 reactor.cc:450] Master_R002: DEBUG: Closing idle connection: Connection (0x00000000027af210) server 10.132.0.2:38643 => 10.128.0.11:7100 - it has been idle for 65.0993s
I0611 06:23:58.895499 12270 reactor.cc:450] Master_R005: DEBUG: Closing idle connection: Connection (0x00000000022cb7b0) server 10.132.0.2:59863 => 10.128.0.11:7100 - it has been idle for 65.0003s
```

Test Plan: Jenkins

Reviewers: bogdan, kannan

Reviewed By: kannan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D8657
deeps1991 pushed a commit to deeps1991/yugabyte-db that referenced this issue Jul 22, 2020
@ttyusupov @deeps1991
yugabyte#4752: Update log message about closing idle connection
e27ca60 
Summary:
Following log messages looks confusing and periodically treated as errors by users:
```
I0611 06:23:58.795145 12268 reactor.cc:450] Master_R003: Timing out connection Connection (0x00000000027afc30) server 10.132.0.2:38383 => 10.128.0.11:7100 - it has been idle for 65.0003s (delta: 65.0003, current time: 34168.1, last activity time: 34103.1)
I0611 06:23:58.795548 12267 reactor.cc:450] Master_R002: Timing out connection Connection (0x00000000027af210) server 10.132.0.2:38643 => 10.128.0.11:7100 - it has been idle for 65.0993s (delta: 65.0993, current time: 34168.1, last activity time: 34103)
I0611 06:23:58.895499 12270 reactor.cc:450] Master_R005: Timing out connection Connection (0x00000000022cb7b0) server 10.132.0.2:59863 => 10.128.0.11:7100 - it has been idle for 65.0003s (delta: 65.0003, current time: 34168.2, last activity time: 34103.2)
```

Updated it to be like:
```
I0611 06:23:58.795145 12268 reactor.cc:450] Master_R003: DEBUG: Closing idle connection: Connection (0x00000000027afc30) server 10.132.0.2:38383 => 10.128.0.11:7100 - it has been idle for 65.0003s
I0611 06:23:58.795548 12267 reactor.cc:450] Master_R002: DEBUG: Closing idle connection: Connection (0x00000000027af210) server 10.132.0.2:38643 => 10.128.0.11:7100 - it has been idle for 65.0993s
I0611 06:23:58.895499 12270 reactor.cc:450] Master_R005: DEBUG: Closing idle connection: Connection (0x00000000022cb7b0) server 10.132.0.2:59863 => 10.128.0.11:7100 - it has been idle for 65.0003s
```

Test Plan: Jenkins

Reviewers: bogdan, kannan

Reviewed By: kannan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D8657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttyusupov ttyusupov

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ttyusupov