Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating cassandra user with no password and attempting to log in crashes tservers #4459

Closed
pmb311 opened this issue May 12, 2020 · 0 comments
Assignees
Labels
community/request Issues created by external users

Comments

@pmb311
Copy link

pmb311 commented May 12, 2020

May 11 21:40:49 shaydb1 yb-tserver[12142]: F0512 01:40:49.321228 6278 ql_value.h:90] Check failed: pb.BOOST_PP_CAT(has_, BOOST_PP_CAT(st
ring, value))() Value:
May 11 21:40:49 shaydb1 yb-tserver[12142]: Fatal failure details written to /usr/scratch/yugabyte/data0/yb-data/tserver/logs/yb-tserver.F
ATAL.details.2020-05-12T01_40_49.pid12142.txt
May 11 21:40:49 shaydb1 yb-tserver[12142]: F20200512 01:40:49 ../../src/yb/common/ql_value.h:90] Check failed: pb.BOOST_PP_CAT(has
, BOOS
T_PP_CAT(string, _value))() Value:
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff8333ef22c yb::LogFatalHandlerSink::send()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff8325da346 google::LogMessage::SendToLog()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff8325d77aa google::LogMessage::Flush()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff8325da879 google::LogMessageFatal::~LogMessageFatal()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff83dc9c73d yb::QLValue::string_value()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff83dc96918 yb::cqlserver::CQLProcessor::ProcessResult()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff83dc98308 yb::cqlserver::CQLProcessor::StatementExecuted()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff83caf5fab yb::ql::Executor::StatementExecuted()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff83caf6d2b yb::ql::Executor::FlushAsync()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff83cafca68 yb::ql::Executor::ProcessAsyncResults()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff834c44948 yb::rpc::(anonymous namespace)::Worker::Execute()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff83347d4af yb::Thread::SuperviseThread()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff82dcb7694 start_thread
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff82d3f441d __clone
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ (nil) (unknown)
May 11 21:40:49 shaydb1 yb-tserver[12142]: *** Check failure stack trace: ***
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff8333ed611 yb::(anonymous namespace)::DumpStackTraceAndExit()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff8325d7c5d google::LogMessage::Fail()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff8325d9dcd google::LogMessage::SendToLog()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff8325d77aa google::LogMessage::Flush()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff8325da879 google::LogMessageFatal::~LogMessageFatal()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff83dc9c73d yb::QLValue::string_value()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff83dc96918 yb::cqlserver::CQLProcessor::ProcessResult()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff83dc98308 yb::cqlserver::CQLProcessor::StatementExecuted()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff83caf5fab yb::ql::Executor::StatementExecuted()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff83caf6d2b yb::ql::Executor::FlushAsync()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff83cafca68 yb::ql::Executor::ProcessAsyncResults()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff834c44948 yb::rpc::(anonymous namespace)::Worker::Execute()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff83347d4af yb::Thread::SuperviseThread()
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff82dcb7694 start_thread
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ 0x7ff82d3f441d __clone
May 11 21:40:49 shaydb1 yb-tserver[12142]: @ (nil) (unknown)
May 11 21:40:50 shaydb1 systemd[1]: yugabyte-tserver.service: Main process exited, code=killed, status=6/ABRT

@yugabyte-ci yugabyte-ci added the community/request Issues created by external users label May 12, 2020
hectorgcr added a commit that referenced this issue May 14, 2020
Summary:
Currently, if we create a role without a password, and then we try to use this role to login, it will cause the yb-tserver process to crash. This happens regardless of the value of the `LOGIN` attribute.

The correct behavior is:
- If the role is allowed to login, then it should return an authentication error saying that the provided password is invalid
- If the role is not allowed to login, it should return an authentication error saying that the user is not allowed to login

Test Plan: New unit tests

Reviewers: oleg, bogdan

Reviewed By: bogdan

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D8460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/request Issues created by external users
Projects
None yet
Development

No branches or pull requests

3 participants