Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] Remove gflags that are deleted from yugabyte configs #4341

Closed
ramkumarvs opened this issue Apr 29, 2020 · 0 comments
Closed

[Platform] Remove gflags that are deleted from yugabyte configs #4341

ramkumarvs opened this issue Apr 29, 2020 · 0 comments
Assignees
@rahuldesirazu
Labels
area/platform Yugabyte Platform

Comments

@ramkumarvs
Copy link
Contributor

Right now we let users delete the gflag in platform side, but we don't go all the way to delete that from yugabyte configs.
@ramkumarvs ramkumarvs added the area/platform Yugabyte Platform label Apr 29, 2020
rahuldesirazu added a commit that referenced this issue May 9, 2020
@rahuldesirazu
[#4341] Remove deleted flags from server.conf
c4c415e 
Summary: Currently we persist flag removal in the YW DB, but we don't delete the entry from the server conf file. This means that on restart, we pick up this entry that should have been deleted. Fix this by adding an ansible task that takes in parameter `gflags_to_remove` list and removes any entries in the server conf that match an entry in this list. This list is generated by YW taking a difference between the UserIntent flags and taskParams() flags.

Test Plan: UpgradeUniverseTest and NodeManagerTest unit tests as well as manual testing of just flag deletion as well as flag deletion + addition together.

Reviewers: bogdan, ram

Reviewed By: ram

Subscribers: jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D8432
@ryan-ally ryan-ally mentioned this issue Nov 30, 2023
Open
@ryan-ally ryan-ally mentioned this issue Feb 11, 2024
Open
@nyndyny nyndyny mentioned this issue Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahuldesirazu rahuldesirazu

Labels
area/platform Yugabyte Platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ramkumarvs @rahuldesirazu