Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid future type code collision in CQL wire protocol for JSONB type #427

Closed
rven1 opened this issue Aug 8, 2018 · 1 comment
Closed

Avoid future type code collision in CQL wire protocol for JSONB type #427

rven1 opened this issue Aug 8, 2018 · 1 comment
Assignees
@rven1

Comments

@rven1
Copy link
Contributor

rven1 commented Aug 8, 2018

JSONB support is a Yugabyte only feature and is not present in Cassandra. The JSONB datatype number in the wire protocol was near the existing data types in Cassandra. So as to avoid future collision with Apache Cassandra drivers, it is required that we use a high number for JSONB's type code in the CQL wire protocol while we are still in beta for JSONB.
@rven1 rven1 self-assigned this Aug 9, 2018
yugabyte-ci pushed a commit that referenced this issue Aug 9, 2018
@rven1
[#427] Change CQL wire protocol to move the JSONB type
9d0085a 
Summary:
Since JSONB is not yet supported by Apache Cassandra, we would like to
move JSONB to a enum value which is far away from the existing range so
as to not conflict with future types added by Cassandra.

Test Plan: Jenkins, org.yb.cql.TestJson

Reviewers: mihnea, robert

Reviewed By: robert

Subscribers: kannan, yql

Differential Revision: https://phabricator.dev.yugabyte.com/D5264
@rven1
Copy link
Contributor Author

rven1 commented Aug 9, 2018

Updated wire protocol.

@rven1 rven1 closed this as completed Aug 9, 2018
jasonyb pushed a commit that referenced this issue Jun 11, 2024
Merge pull request #427 from Naeem-Akhter/pg16
a35689b 
Added workflow file for pgsm ppg-16 package testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rven1 rven1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rven1