Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tablet log prefix is missing ": " #4188

Closed
ttyusupov opened this issue Apr 10, 2020 · 0 comments
Closed

Tablet log prefix is missing ": " #4188

ttyusupov opened this issue Apr 10, 2020 · 0 comments
Assignees
@ttyusupov
Labels
kind/bug This issue is a bug

Comments

@ttyusupov
Copy link
Contributor

For example:

I0410 16:08:13.286401 32103 tablet.cc:494] T bbe2f819022146c5ba80758f58743ac7 P c375fccb20004daebff116167109ff6fCreating RocksDB database in dir...
@ttyusupov ttyusupov added the kind/bug This issue is a bug label Apr 10, 2020
@ttyusupov ttyusupov self-assigned this Apr 10, 2020
ttyusupov added a commit that referenced this issue Apr 10, 2020
@ttyusupov
#4188: Fixed tablet log prefix
09929fe 
Summary:
Tablet log-prefix has been broken and as a result there is no ": " in logs of tablet.cc:
```
I0410 16:08:13.286401 32103 tablet.cc:494] T bbe2f819022146c5ba80758f58743ac7 P c375fccb20004daebff116167109ff6fCreating RocksDB database in dir...
```

- Fixed `MakeTabletLogPrefix` function inside `tablet.cc`
- Added missing regular/intents DB prefix into logs of `Tablet::CreateSubtablet`.

After the fix:
```
I0410 18:02:46.600347  7522 tablet.cc:494] T 00000000000000000000000000000000 P b52e72c5703c4b9b9cbe032327be81ca: Creating RocksDB database in dir  ...
```

Test Plan: - `ybd --cxx-test tablet-split-itest | grep 'tablet.cc'` and check logs.

Reviewers: bogdan

Reviewed By: bogdan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D8269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttyusupov ttyusupov

Labels
kind/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ttyusupov