Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nodiscard attribute to Status class #3918

Closed
spolitov opened this issue Mar 11, 2020 · 0 comments
Closed

Add nodiscard attribute to Status class #3918

spolitov opened this issue Mar 11, 2020 · 0 comments
Assignees
@spolitov
Labels
area/docdb YugabyteDB core features

Comments

@spolitov
Copy link
Contributor

No description provided.

@spolitov spolitov added the area/docdb YugabyteDB core features label Mar 11, 2020
@spolitov spolitov self-assigned this Mar 11, 2020
spolitov added a commit that referenced this issue Mar 13, 2020
@spolitov
[#3918] Add nodiscard attribute to Status class
99ea016 
Summary:
Since C++17 there is nodiscard attribute, that clang supports even for C++14 which is used for our builds.
This diff adds such attribute to Status class and fixes build issues introduced by a new check.

Disabled this attribute for tests and RocksDB tools, since there are too many places where Status is ignored.

Test Plan: Jenkins

Reviewers: mikhail, dmitry

Reviewed By: dmitry

Subscribers: ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D8122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
area/docdb YugabyteDB core features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spolitov