Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dist-txns] Support batch request for DML on table with secondary index #388

Closed
robertpang opened this issue Jul 19, 2018 · 1 comment
Closed

[dist-txns] Support batch request for DML on table with secondary index #388

robertpang opened this issue Jul 19, 2018 · 1 comment
Assignees
@robertpang
Labels
kind/enhancement This is an enhancement of an existing feature

Comments

@robertpang
Copy link
Contributor

Currently YCQL batch request does not allow DML statements on a table with secondary index inside a batch. We should add the support for such DML statements in a batch.
@robertpang robertpang added the kind/enhancement This is an enhancement of an existing feature label Jul 19, 2018
@robertpang robertpang self-assigned this Jul 19, 2018
yugabyte-ci pushed a commit that referenced this issue Aug 9, 2018
@robertpang
#388: Support batch request of DMLs on table with secondary index
36953b4 
Summary:
Support batch request of DMLs on table with secondary index. To allow this, the YCQL executor is reorganized:
- Transaction and the associated YBSession is now maintained by ExecContext instead of QLEnv to allow multiple transactions per execution. The Executor maintains a separate YBSession for non-transactional read/write operations.
- Read/write operations are flushed and transactions are committed in rounds. In each round, buffered operations in all YBSessions are flushed and transactions ready to commit are committed. As each FlushAsyncDone and CommitDone callback is called, error is checked. Only when all callbacks are called in each round will results be processed and the next round of flushes and commits be issued.
- The rescheduling of YCQL calls to satisfy thread-restriction is reorganized.

Test Plan: Jenkins

Reviewers: mihnea

Reviewed By: mihnea

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D5237
@robertpang
Copy link
Contributor Author

Implemented in commit 36953b4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertpang robertpang

Labels
kind/enhancement This is an enhancement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertpang