-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yb-ctl] make remove_node destroy node data #3771
Comments
Actually, it seems
|
Actually, I think that this is somewhat a somewhat reasonable issue:
Similarly, we should have
|
Summary: We had a couple data races in the CDC Poller. 1. Although the poller is called in a serial fashion, critical call stacks are placed upon a ThreadPool. This is not guaranteed to always enqueue on the same thread and can create a situation where the ThreadPool is processing the call before a cache flush of the local data has occured on the originating thread. Added a mutex to guarantee ordering. 2. A race existed within TwoDCOutputClient where failing call OpenTable would not properly reset the OpID or ErrorStatus. Modified code to call HandleError, which has standardized handling here. Test Plan: ybd tsan --cxx-test twodc-test --gtest_filter BatchSize/TwoDCTest.ApplyOperationsRandomFailures/1 -n 1000 Reviewers: rahuldesirazu, neha, hector Reviewed By: neha, hector Subscribers: ybase, bogdan Differential Revision: https://phabricator.dev.yugabyte.com/D8075
Jira Link: DB-10819
Currently,
remove_node
andstop_node
commands do the same thing: stop the node. There is no way to kill a node. Add that ability, preferably by changing the behavior of the redundantremove_node
command.The text was updated successfully, but these errors were encountered: