-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Redis LIST #338
Comments
It would be great to support LTRIM on YQL too. |
Hi @ddorian, great suggestion. Do you mind opening a separate issue for that so we track it? Guessing you are referring to something like: https://www.w3schools.com/sql/func_sqlserver_ltrim.asp |
Hi @rkarthik007 [I had this confusion too in a separate context. LTRIM in SQL is a string function, and in Redis it is a list function.] Here I think @ddorian is asking for the Redis LTRIM (https://redis.io/commands/ltrim). So we can just track this in this same github issue. I think @bmatican just gave a few sample commands like (LPUSH/LPOP), but we should just plan on implementing LTRIM also as part of the LIST implementation in YEDIS. regards, |
But yes, @ddorian , if you were referring to LTRIM in the YCQL (Cassandra-compatible API), then please could you create a separate issue for that? |
@kmuthukk @rkarthik007 I meant having the same functionality of this issue on YQL too. |
@ddorian YQL refers to YugaByte's internal Query Layer that forms the basis for our multiple APIs (and is not an API in itself). The APIs we have today are YCQL (Cassandra-compatible), YEDIS (Redis-compatible) and PostgreSQL. Can you pls confirm that when you are referring to YQL you actually mean YCQL? |
@schoudhury My bad, I meant the YCQL. |
Ok, so my misunderstanding. Part of it is due to the terminology. Let me elaborate: YQL (YugaByte Query Layer) is a component name we have been using to refer to the multi-model query layer component in our implementation and it implements/exposes the following user facing APIs:
So to make sure, you are asking for LTRIM (list trim) support in YCQL |
@kmuthukk |
Summary: Adding support for LPOP, RPOP, LPUSH, RPUSH, LLEN. Main modifications are to the ExtendList and ReplaceInList functions in doc_write_batch.cc. Test Plan: New unit test in redisserver-test.cc Reviewers: mikhail, rahuldesirazu, mihnea Reviewed By: mihnea Subscribers: kannan, yql Differential Revision: https://phabricator.dev.yugabyte.com/D5405
This is partially done in 0d9feb2. Closing as no current plans to extend support beyond that. |
PG-488: Revert pg_stat_monitor: Overflow management. This patch does not work for < PostgreSQL - 15. More work required.
We should support the LIST data type and at least some subset of the commands for it, ideally both LPUSH/LPOP and RPUSH/RPOP so it could be used as a queue. See: #329 (comment) for a user requirement.
https://redis.io/commands#list
The text was updated successfully, but these errors were encountered: