Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis - Feature flag to disable FLUSHALL and FLUSHDB commands #337

Closed
udayshanmugam opened this issue Jun 19, 2018 · 0 comments
Closed

Redis - Feature flag to disable FLUSHALL and FLUSHDB commands #337

udayshanmugam opened this issue Jun 19, 2018 · 0 comments
Assignees
@vitsai
Labels
kind/enhancement This is an enhancement of an existing feature

Comments

@udayshanmugam
Copy link

Enhancement
Redis - A feature flag to disable FLUSHALL and FLUSHDB commands will be helpful in production environments to prevent mistakes
@bmatican bmatican assigned bmatican and vitsai and unassigned bmatican Jun 19, 2018
@kmuthukk kmuthukk added the kind/enhancement This is an enhancement of an existing feature label Jun 19, 2018
yugabyte-ci pushed a commit that referenced this issue Jun 21, 2018
@vitsai
ENG-3481: added option to disable flushall in redis (#337)
31563f2 
Summary:
Added option to disable flushall in redis

shortened lines

Test Plan:
Modified flushall unit tests to test flag on, flag off
Also yb-ctl sanity check:

./bin/yb-ctl create --tserver_flags "yedis_enable_flush=false"
./bin/yb-ctl setup_redis
./bin/redis-cli
//manually check flushall and exit + destroy

ybd debug --cxx-test redisserver_redisserver-test --gtest_filter TestRedisService.TestFlushDb -n 100
ybd debug --cxx-test redisserver_redisserver-test --gtest_filter TestRedisService.TestFlushAll -n 100

Reviewers: amitanand, bogdan, pritam.damania

Reviewed By: pritam.damania

Subscribers: kannan, karthik, yql

Differential Revision: https://phabricator.dev.yugabyte.com/D4995
@vitsai vitsai closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitsai vitsai

Labels
kind/enhancement This is an enhancement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bmatican @udayshanmugam @vitsai @kmuthukk