Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[yugabyted] Esc key does not close popups #3211

Closed
jaki opened this issue Dec 20, 2019 · 2 comments
Closed

[yugabyted] Esc key does not close popups #3211

jaki opened this issue Dec 20, 2019 · 2 comments
Assignees
@andrewc-dev
Labels
area/ui All issues relating to UI/UX priority/low Low priority

Comments

@jaki
Copy link
Contributor

jaki commented Dec 20, 2019

In the yugabyted UI, it is not uncommon to encounter popup windows. One would expect these windows to close by pressing the Escape key, but it currently does not. Add that support.
@jaki jaki added the area/ui All issues relating to UI/UX label Dec 20, 2019
@iSignal iSignal assigned andrewc-dev and unassigned WesleyW Dec 23, 2019
@iSignal iSignal added the priority/low Low priority label Dec 23, 2019
@iSignal
Copy link
Contributor

iSignal commented Dec 23, 2019

Jason, is this specific to the yugabyted pop up or have you encountered other pop ups in yugaware that do the same thing?

@jaki
Copy link
Contributor Author

jaki commented Dec 23, 2019 •
edited
Loading

I had not encountered this in the general master or tserver UIs after having tried to for a bit. I have just tried Yugaware, and I am getting this behavior with expanding the maps and "Restore Backup" button.

andrewc-dev pushed a commit that referenced this issue Feb 18, 2020
[YW][#3211] Add ESC key binding to document to close any modal on the…
6ba9b05 
… screen by calling the onHide callback.

Summary: Add document event listener on 'esc' key for the modal component.

Test Plan:
Try opening any modal, such as the new user introduction modal, full move confirm modal,
or region/zone selection modal when configuring a cloud provider. Confirm if pressing ESC closes the
modal on the screen.

Reviewers: ram, jason

Reviewed By: jason

Subscribers: ui

Differential Revision: https://phabricator.dev.yugabyte.com/D7973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewc-dev andrewc-dev

Labels
area/ui All issues relating to UI/UX priority/low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@WesleyW @iSignal @jaki @andrewc-dev