[YSQL] Portal restart data collection should not rely on unnamed_stmt_psrc #2975
Comments
frozenspider
added a commit
that referenced
this issue
Nov 22, 2019
… fix a bug with unnamed_stmt_psrc Summary: This revision addresses two issues. 1) [[ #2974 | #2974 ]]: Instead of 8 KiB hardcoded `PQ_SEND_BUFFER_SIZE`, output buffer size is now controlled by a `ysql_output_buffer_size` gflag, with default value of 256 KiB. Test has been amended accordingly. 2) [[ #2975 | #2975 ]]: Fixed bug with getting values from `unnamed_stmt_psrc` when collecting portal restart data. We were relying on it always matching current statement, but after increasing buffer size it turned out that this isn't in fact guaranteed. Changed `yb_collect_portal_restart_data` to only rely on portal itself. Depends on D7549 Test Plan: ./yb_build.sh --java-test org.yb.pgsql.TestPgReadRestarts Reviewers: neil, neha, dmitry, kannan, mihnea, mikhail Reviewed By: mihnea, mikhail Subscribers: yql Differential Revision: https://phabricator.dev.yugabyte.com/D7591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
yb_collect_portal_restart_dataimplemented for #1237, we were collecting some values fromunnamed_stmt_psrc. We were relying on it always matching current statement, but after increasing buffer size it turned out that this isn't in fact guaranteed. We need to changeyb_collect_portal_restart_datato only rely on portal itself.The text was updated successfully, but these errors were encountered: