Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more logging to rocksdb corruption message #2961

Closed
rahuldesirazu opened this issue Nov 19, 2019 · 0 comments
Closed

Add more logging to rocksdb corruption message #2961

rahuldesirazu opened this issue Nov 19, 2019 · 0 comments
Assignees
@ttyusupov @rahuldesirazu
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature

Comments

@rahuldesirazu
Copy link
Contributor

As part of rocksdb corruption message, include a stack trace and some more info on which file actually got corrupted.
@rahuldesirazu rahuldesirazu added kind/bug This issue is a bug area/docdb YugabyteDB core features labels Nov 19, 2019
@rahuldesirazu rahuldesirazu self-assigned this Nov 19, 2019
ttyusupov added a commit that referenced this issue Dec 27, 2019
@ttyusupov
#2961: Improved rocksdb corruption error logging
c5ced74 
Summary:
Improved rocksdb block read corruption error logging
- Added filename and block handle to error message
- Added logging stacktrace

Test Plan:
- Jenkins
- Manually tested on internal test cluster with corrupted file

Reviewers: mikhail, sergei

Reviewed By: sergei

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D7745
@ttyusupov ttyusupov self-assigned this Dec 27, 2019
@ttyusupov ttyusupov added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttyusupov ttyusupov

@rahuldesirazu rahuldesirazu

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ttyusupov @rahuldesirazu