Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check failed: state_ == BatcherState::kTransactionReady (kComplete vs. kTransactionReady) #2879

Closed
mbautin opened this issue Nov 7, 2019 · 3 comments
Closed

Check failed: state_ == BatcherState::kTransactionReady (kComplete vs. kTransactionReady) #2879

mbautin opened this issue Nov 7, 2019 · 3 comments
Assignees
@mbautin @spolitov
Labels
area/cdc Change Data Capture area/docdb YugabyteDB core features priority/high High Priority

Comments

@mbautin
Copy link
Contributor

mbautin commented Nov 7, 2019

Happens in org.yb.cql.TestAuthorizationEnforcement#testDropIndexWithAlterTablePermission

https://gist.githubusercontent.com/mbautin/f16b1edf47f808d0a24947335920ac75/raw
Full log: https://gist.githubusercontent.com/mbautin/ef229d8b8a65e1e792fcecd32f90e1c3/raw
@ndeodhar ndeodhar added area/docdb YugabyteDB core features area/cdc Change Data Capture labels Nov 8, 2019
@ndeodhar
Copy link
Contributor

ndeodhar commented Nov 8, 2019

Also saw this during 2DC testing on the producer cluster.

@kmuthukk kmuthukk added the priority/high High Priority label Nov 11, 2019
@kmuthukk
Copy link
Collaborator

We saw another instance of this in pf-3 cluster. Looks like something recent is triggering this.

spolitov added a commit that referenced this issue Nov 12, 2019
@spolitov
[#2879] Change failure handling in ProcessRpcStatus
8fe04d8 
Summary:
Batcher::ProcessRpcStatus performs a sanity check, that batcher is in the correct state - kTransactionReady.
But this check is done outside of the lock, while `state_` should be accessed only while holding the mutex.

Fixed it, and replaced CHECK_EQ with LOG(DFATAL).

Test Plan: Jenkins

Reviewers: bogdan, amitanand, timur, mikhail

Reviewed By: mikhail

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D7548
@spolitov
Copy link
Contributor

Fixed by 401e821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbautin mbautin

@spolitov spolitov

Labels
area/cdc Change Data Capture area/docdb YugabyteDB core features priority/high High Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mbautin @spolitov @kmuthukk @ndeodhar