Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache universe key registry in memory on YW side #2770

Closed
daniel-yb opened this issue Oct 29, 2019 · 0 comments
Closed

Cache universe key registry in memory on YW side #2770

daniel-yb opened this issue Oct 29, 2019 · 0 comments
Assignees
@daniel-yb
Labels
area/platform Yugabyte Platform

Comments

@daniel-yb
Copy link
Contributor

daniel-yb commented Oct 29, 2019 •
edited
Loading

To prepare for #2728 YW should be caching the latest key ref for a universe -> key value in memory such that it does not need to make API requests every single time it wants to send the same encryption key to masters.
@daniel-yb daniel-yb added the area/platform Yugabyte Platform label Oct 29, 2019
@daniel-yb daniel-yb self-assigned this Oct 29, 2019
daniel-yb added a commit that referenced this issue Nov 5, 2019
@daniel-yb
Cache universe key registry in memory on YW side #2770
dc265d7 
Summary:
To prepare for #2728, the latest key ref -> key val for each universe should be cached in memory on the
platform side of things to get rid of the need to make API calls on every retrieve key
request

Test Plan:
Make multple retrieve key calls in a row with the same parameters, ensure that API
requests should be made against the kms key provider at most one time while all subsequent retrieve
key calls should retrieve the key from in-memory cache.

Reviewers: ram, sanketh

Reviewed By: sanketh

Subscribers: jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D7486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-yb daniel-yb

Labels
area/platform Yugabyte Platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daniel-yb