[DocDB] Flaky test YbAdminSnapshotScheduleTest.PgsqlAddColumnCompactWithPackedRow #24310
Open
1 task done
Assignees
Labels
area/docdb
YugabyteDB core features
kind/enhancement
This is an enhancement of an existing feature
kind/failing-test
Tests and testing infra
priority/medium
Medium priority issue
Comments
yugabyte-ci
added
kind/failing-test
spolitov
added a commit
that referenced
this issue
Dec 26, 2024
…t schedule is enabled Summary: When snapshot schedule is active, we retain records from being compacted until there is snapshot that contains this record. Due to race condition we could get into situation where tablet replica consider snapshot as taken while it does not have it. TServer receives last schedule snapshot time via heartbeat mechanism. There are 2 places that could lead to described bug. 1) Master sends last snapshot time for schedule that is not yet complete. 2) Snapshot is taken on leader and one follower, while another follower did not complete snapshot yet. Fixed by switching to maintain last snapshot time locally and store this information in filesystem. When snapshot is created for some schedule, we create file in snapshots folder named: last_snapshot.[SCHEDULE_ID].[SNAPSHOT_TIME]. And remove previous file for the same schedule. During tablet bootstrap we list all files in snapshot folder, recovering latest snapshot times and removing outdated files. Jira: DB-13199 Test Plan: ./yb_build.sh release -n 400 --gtest_filter YbAdminSnapshotScheduleTest.PgsqlAddColumnCompactWithPackedRow -- -p 8 Reviewers: timur Reviewed By: timur Subscribers: ybase Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D40893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-13199
Description
YbAdminSnapshotScheduleTest.PgsqlAddColumnCompactWithPackedRow is flaky because it expects snapshot creation is finished before doing
Alter table add columnbut there's race condition between them.Issue Type
kind/failing-test
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: