Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDC] Increase WAL retention time when CDC stream is created through a SetupUniverseReplication request #2375

Closed
hectorgcr opened this issue Sep 19, 2019 · 0 comments
Closed

[CDC] Increase WAL retention time when CDC stream is created through a SetupUniverseReplication request #2375

hectorgcr opened this issue Sep 19, 2019 · 0 comments
Assignees
@hectorgcr
Labels
area/cdc Change Data Capture

Comments

@hectorgcr
Copy link
Contributor

Currently we don't modify the WAL retention time when a CDC stream is created through a SetupUniverseReplication request that is sent directly to the master. This is related to #2050.
@hectorgcr hectorgcr added the area/cdc Change Data Capture label Sep 19, 2019
@hectorgcr hectorgcr self-assigned this Sep 19, 2019
hectorgcr added a commit that referenced this issue Oct 2, 2019
@hectorgcr
#2375: [WIP] [CDC] Increase WAL retention time when CDC stream is cre…
b23c936 
…ated through a SetupUniverseReplication request

Summary:
Currently the WAL retention time is being modified in the CDC service by the method `CDCServiceImpl::CreateCDCStream`.

As part of the `SetupUniverseReplication` process, we create CDC streams for all the specified tables in the request. Because `CatalogManager::SetupUniverseReplication` create CDC streams by calling `CatalogManager::CreateCDCStream`, the WAL retention time for these tablets won't get modified.

This diff moves the modification of the WAL retention time from  `CDCServiceImpl::CreateCDCStream` to `CatalogManager::CreateCDCStream`. Because `CatalogManager::CreateCDCStream` will be called by `CDCServiceImpl::CreateCDCStream`, the WAL retention time will be modified regardless of how the CDC stream was created.

Test Plan:
ybd release --cxx-test integration-tests_cdc_service-int-test --gtest_filter CDCServiceTest.TestCreateCDCStreamWithDefaultRententionTime -n 100

ybd release --cxx-test integration-tests_twodc-test --gtest_filter TwoDCTest.TestWalRetentionSet -n 100

Reviewers: nicolas, neha, mikhail

Reviewed By: nicolas, neha

Subscribers: sergei, ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D7246
@ndeodhar ndeodhar closed this as completed Oct 3, 2019
@ryan-ally ryan-ally mentioned this issue Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hectorgcr hectorgcr

Labels
area/cdc Change Data Capture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ndeodhar @hectorgcr