Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Unit test failure PgOnConflictTest.OnConflictWithKillMaster #2334

Closed
nocaway opened this issue Sep 16, 2019 · 0 comments
Closed

[YSQL] Unit test failure PgOnConflictTest.OnConflictWithKillMaster #2334

nocaway opened this issue Sep 16, 2019 · 0 comments
Assignees
@mbautin @spolitov
Labels
kind/bug This issue is a bug

Comments

@nocaway
Copy link
Contributor

nocaway commented Sep 16, 2019 •
edited
Loading

Symptoms
ybd --cxx-test pgwrapper_pg_on_conflict-test --gtest_filter PgOnConflictTest.OnConflictWithKillMaster

  • The test "PgOnConflictTest.OnConflictWithKillMaster" has NEVER passed since its creation.
  • It continued to fail after the following commit from @sergei.
commit 5236661e62b9d2829c4f83a39d184d64f4f5830e
Author: Sergei Politov <spolitov@gmail.com>
Date:   2019-09-06

    [#2222]: Stabilize PgLibPqTest.OnConflictWithKillMaster
@nocaway nocaway added the kind/bug This issue is a bug label Sep 16, 2019
spolitov added a commit that referenced this issue Sep 20, 2019
@spolitov
[#2334]: Increase master kill interval in ASAN mode of PgOnConflictTe…
6c8d530 
…st.OnConflictWithKillMaster

Summary:
In PgOnConflictTest.OnConflictWithKillMaster we kill master for some time, then resume it.
Recently master bootstrap was slowed down, so 15 it is not enough to bootstrap and process requests.
So requests started to time out.

Increased master kill interval in ASAN mode to 45 seconds.

Also several cosmetic fixes:
1) Delay retry in case of the single yet ready master.
2) Use same single RPC timeout for lookup as used for read and write.

Test Plan: ybd asan --gtest_filter PgOnConflictTest.OnConflictWithKillMaster -n 50

Reviewers: neil, mikhail, timur

Reviewed By: timur

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D7232
spolitov added a commit that referenced this issue Sep 20, 2019
@spolitov
[#2334]: Propagate timeout to transaction
511d384 
Summary:
The transaction is executed as part of other operation, which has his own deadline.
And internal transaction requests should use the same deadline.

Test Plan: ybd debug --cxx-test pgwrapper_pg_on_conflict-test --gtest_filter PgOnConflictTest.OnConflictWithKillMaster --clang -n 10

Reviewers: mikhail, neil, timur

Reviewed By: timur

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D7253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbautin mbautin

@spolitov spolitov

Labels
kind/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbautin @spolitov @nocaway