[DocDB] Update DBUnit tests to exercise smaller batch size - ysql_session_max_batch_size #21430
Closed
1 task done
Assignees
Labels
2024.1 Backport Required
area/docdb
YugabyteDB core features
kind/enhancement
This is an enhancement of an existing feature
priority/medium
Medium priority issue
Comments
rthallamko3
added
area/docdb
yugabyte-ci
added
kind/enhancement
basavaraj29
added a commit
that referenced
this issue
May 1, 2024
…h size Summary: Running a couple of existing unit test would have uncovered issues like #18394 and #21736. Hence, enhancing the wait-queue test suite to trigger a few of the existing tests with smaller batch size. Most of the `PgWaitQueuesTest` tests execute point updates/lookups that end up in the wait-queue. Re-running these tests with a smaller batch size doesn't give us any useful signal. To minimize test times, the diff exercises the smaller batch size codepath only for select `PgWaitQueuesTest` test with bulk updates/lookups. This approach also helps preserve test stability history. For existing `PgWaitQueueRF1Test` tests, 2/3 execute bulk updates. Hence going with `INSTANTIATE_TEST_SUITE_P` approach for these tests, making all `PgWaitQueueRF1Test` tests execute under both small and normal batch sizes. Jira: DB-10311 Test Plan: Jenkins ./yb_build.sh --cxx-test pgwrapper_pg_wait_on_conflict-test Reviewers: rsami, rthallam Reviewed By: rsami Subscribers: ybase, yql Differential Revision: https://phorge.dev.yugabyte.com/D34454
basavaraj29
added a commit
that referenced
this issue
May 6, 2024
…cise smaller batch size Summary: Original commit: 4a4cab8 / D34454 Running a couple of existing unit test would have uncovered issues like #18394 and #21736. Hence, enhancing the wait-queue test suite to trigger a few of the existing tests with smaller batch size. Most of the `PgWaitQueuesTest` tests execute point updates/lookups that end up in the wait-queue. Re-running these tests with a smaller batch size doesn't give us any useful signal. To minimize test times, the diff exercises the smaller batch size codepath only for select `PgWaitQueuesTest` test with bulk updates/lookups. This approach also helps preserve test stability history. For existing `PgWaitQueueRF1Test` tests, 2/3 execute bulk updates. Hence going with `INSTANTIATE_TEST_SUITE_P` approach for these tests, making all `PgWaitQueueRF1Test` tests execute under both small and normal batch sizes. Jira: DB-10311 Test Plan: Jenkins ./yb_build.sh --cxx-test pgwrapper_pg_wait_on_conflict-test Reviewers: rsami, rthallam Reviewed By: rthallam Subscribers: yql, ybase Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D34761
github-project-automation
bot
moved this from Backporting
to Done
in Wait-Queue Based Locking
svarnau
pushed a commit
that referenced
this issue
May 25, 2024
…h size Summary: Running a couple of existing unit test would have uncovered issues like #18394 and #21736. Hence, enhancing the wait-queue test suite to trigger a few of the existing tests with smaller batch size. Most of the `PgWaitQueuesTest` tests execute point updates/lookups that end up in the wait-queue. Re-running these tests with a smaller batch size doesn't give us any useful signal. To minimize test times, the diff exercises the smaller batch size codepath only for select `PgWaitQueuesTest` test with bulk updates/lookups. This approach also helps preserve test stability history. For existing `PgWaitQueueRF1Test` tests, 2/3 execute bulk updates. Hence going with `INSTANTIATE_TEST_SUITE_P` approach for these tests, making all `PgWaitQueueRF1Test` tests execute under both small and normal batch sizes. Jira: DB-10311 Test Plan: Jenkins ./yb_build.sh --cxx-test pgwrapper_pg_wait_on_conflict-test Reviewers: rsami, rthallam Reviewed By: rsami Subscribers: ybase, yql Differential Revision: https://phorge.dev.yugabyte.com/D34454
ZhenYongFan
pushed a commit
to ZhenYongFan/yugabyte-db
that referenced
this issue
Jun 15, 2024
… to exercise smaller batch size Summary: Original commit: 4a4cab8 / D34454 Running a couple of existing unit test would have uncovered issues like yugabyte#18394 and yugabyte#21736. Hence, enhancing the wait-queue test suite to trigger a few of the existing tests with smaller batch size. Most of the `PgWaitQueuesTest` tests execute point updates/lookups that end up in the wait-queue. Re-running these tests with a smaller batch size doesn't give us any useful signal. To minimize test times, the diff exercises the smaller batch size codepath only for select `PgWaitQueuesTest` test with bulk updates/lookups. This approach also helps preserve test stability history. For existing `PgWaitQueueRF1Test` tests, 2/3 execute bulk updates. Hence going with `INSTANTIATE_TEST_SUITE_P` approach for these tests, making all `PgWaitQueueRF1Test` tests execute under both small and normal batch sizes. Jira: DB-10311 Test Plan: Jenkins ./yb_build.sh --cxx-test pgwrapper_pg_wait_on_conflict-test Reviewers: rsami, rthallam Reviewed By: rthallam Subscribers: yql, ybase Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D34761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-10311
Description
If we set
ysql_session_max_batch_sizeto a lower value for all the tests in pg_wait_on_conflict test suite, say something like 1, then there would be better coverage for issue #18394 (2-3 tests that explicitly fail with the duplicate request error prior to the fix).Issue Type
kind/enhancement
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: