Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] flaky test: GeoTransactionsPromotionConflictAbortTest.TestConflictAbortBeforeNewHeartbeat #20518

Closed
1 task done
bmatican opened this issue Jan 9, 2024 · 1 comment
Closed
1 task done

[DocDB] flaky test: GeoTransactionsPromotionConflictAbortTest.TestConflictAbortBeforeNewHeartbeat #20518

bmatican opened this issue Jan 9, 2024 · 1 comment
Assignees
@es1024
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature kind/failing-test Tests and testing infra priority/medium Medium priority issue

Comments

@bmatican
Copy link
Contributor

bmatican commented Jan 9, 2024 •
edited by jira bot
Loading

Jira Link: DB-9524

Description

https://detective-gcp.dev.yugabyte.com/stability/test?analyze_trends=true&branch=master&build_type=all&class=GeoTransactionsPromotionConflictAbortTest&fail_tag=all&name=TestConflictAbortBeforeNewHeartbeat&num_commits=500&platform=linux

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@bmatican bmatican added kind/failing-test Tests and testing infra area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Jan 9, 2024
@yugabyte-ci yugabyte-ci added priority/medium Medium priority issue kind/enhancement This is an enhancement of an existing feature and removed status/awaiting-triage Issue awaiting triage labels Jan 9, 2024
es1024 added a commit that referenced this issue Feb 8, 2024
@es1024
[#20518] docdb: Adjust waits in GeoTransactionsPromotionConflictAbort…
0214819 
…Test.TestConflictAbortBeforeNewHeartbeat

Summary:
GeoTransactionsPromotionConflictAbortTest.TestConflictAbortBeforeNewHeartbeat attempts to simulate a race condition that happens before the first heartbeat of a transaction. On slower builds like TSAN (and to a lesser degree, mac), things often take long enough that we fail to set up the race condition before the first heartbeat at 1500ms (TSAN)/500ms (non-TSAN).

This build increases all waits and heartbeat interval by several times to reduce flakiness.
Jira: DB-9524

Test Plan: Jenkins, triggered to run TSAN 100x, fail rate goes from ~70% to ~5% (remaining fails are a different issue where test isn't getting cleaned up).

Reviewers: sergei, bogdan

Reviewed By: bogdan

Subscribers: ybase, yql

Differential Revision: https://phorge.dev.yugabyte.com/D31867
@es1024
Copy link
Contributor

es1024 commented Feb 8, 2024

Fixed in 0214819

@es1024 es1024 closed this as completed Feb 8, 2024
@es1024 es1024 mentioned this issue Mar 13, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@es1024 es1024

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature kind/failing-test Tests and testing infra priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmatican @es1024 @yugabyte-ci